Merge pull request #18748 from nextcloud/backport/18740/stable16

[stable16] cache group existence early to save useless requests to LDAP

Author: blizzz

apps/user_ldap/lib/Access.php

@@ -345,7 +345,7 @@ public function extractRangeData($result, $attribute) {
 		}
 		return [];
 	}
-	
+
 	/**
 	 * Set password for an LDAP user identified by a DN
 	 *
@@ -646,6 +646,8 @@ public function mapAndAnnounceIfApplicable(
 			if ($this->ncUserManager instanceof PublicEmitter && $isUser) {
 				$this->cacheUserExists($name);
 				$this->ncUserManager->emit('\OC\User', 'assignedUserId', [$name]);
+			} elseif (!$isUser) {
+				$this->cacheGroupExists($name);
 			}
 			return true;
 		}
@@ -749,6 +751,13 @@ public function cacheUserExists($ocName) {
 		$this->connection->writeToCache('userExists'.$ocName, true);
 	}
 
+	/**
+	 * caches a group as existing
+	 */
+	public function cacheGroupExists(string $gid): void {
+		$this->connection->writeToCache('groupExists'.$gid, true);
+	}
+
 	/**
 	 * caches the user display name
 	 * @param string $ocName the internal Nextcloud username
@@ -938,7 +947,15 @@ public function batchApplyUserAttributes(array $ldapRecords){
 	 * @return array
 	 */
 	public function fetchListOfGroups($filter, $attr, $limit = null, $offset = null) {
-		return $this->fetchList($this->searchGroups($filter, $attr, $limit, $offset), $this->manyAttributes($attr));
+		$groupRecords = $this->searchGroups($filter, $attr, $limit, $offset);
+		array_walk($groupRecords, function($record) {
+			$newlyMapped = false;
+			$gid = $this->dn2ocname($record['dn'][0], null, false, $newlyMapped, $record);
+			if(!$newlyMapped && is_string($gid)) {
+				$this->cacheGroupExists($gid);
+			}
+		});
+		return $this->fetchList($groupRecords, $this->manyAttributes($attr));
 	}
 
 	/**

apps/user_ldap/lib/Group_LDAP.php

@@ -1146,7 +1146,7 @@ public function createGroup($gid) {
 						$uuid,
 						false
 					);
-					$this->access->connection->writeToCache("groupExists" . $gid, true);
+					$this->access->cacheGroupExists($gid);
 				}
 			}
 			return $dn != null;