handle AccessDenied error when checking if external s3 support versions

mgallien · mgallien · commit 54c05bcdb96f · 2022-07-28T09:20:12.000Z
Signed-off-by: Matthieu Gallien &lt;matthieu.gallien@nextcloud.com&gt;
diff --git a/apps/files_external/lib/Lib/Storage/AmazonS3.php b/apps/files_external/lib/Lib/Storage/AmazonS3.php
@@ -744,7 +744,7 @@ protected function getVersioningStatusFromBucket(): bool {
 			return $result->get('Status') === 'Enabled';
 		} catch (S3Exception $s3Exception) {
 			// This is needed for compatibility with Storj gateway which does not support versioning yet
-			if ($s3Exception->getAwsErrorCode() === 'NotImplemented') {
+			if ($s3Exception->getAwsErrorCode() === 'NotImplemented' || $s3Exception->getAwsErrorCode() === 'AccessDenied') {
 				return false;
 			}
 			throw $s3Exception;

Original file line number	Diff line number	Diff line change
`@@ -744,7 +744,7 @@ protected function getVersioningStatusFromBucket(): bool {`
`744`	`744`	`return $result->get('Status') === 'Enabled';`
`745`	`745`	`} catch (S3Exception $s3Exception) {`
`746`	`746`	`// This is needed for compatibility with Storj gateway which does not support versioning yet`
`747`		`- if ($s3Exception->getAwsErrorCode() === 'NotImplemented') {`
	`747`	`+ if ($s3Exception->getAwsErrorCode() === 'NotImplemented' \|\| $s3Exception->getAwsErrorCode() === 'AccessDenied') {`
`748`	`748`	`return false;`
`749`	`749`	`}`
`750`	`750`	`throw $s3Exception;`