fix: merge the router tests to avoid issues with multiple instances and include_once

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Author: kesselb

tests/lib/Route/RouterTest.php

@@ -39,9 +39,8 @@
  * @package Test\Route
  */
 class RouterTest extends TestCase {
-	private Router $router;
-	protected function setUp(): void {
-		parent::setUp();
+
+	public function testGenerate(): void {
 		/** @var LoggerInterface $logger */
 		$logger = $this->createMock(LoggerInterface::class);
 		$logger->method('info')
@@ -50,27 +49,30 @@ function (string $message, array $data) {
 					$this->fail('Unexpected info log: '.(string)($data['exception'] ?? $message));
 				}
 			);
-		$this->router = new Router(
+		$router = new Router(
 			$logger,
 			$this->createMock(IRequest::class),
 			$this->createMock(IConfig::class),
 			$this->createMock(IEventLogger::class),
 			$this->createMock(ContainerInterface::class),
 		);
-	}
 
-	public function testHeartbeat(): void {
-		$this->assertEquals('/index.php/heartbeat', $this->router->generate('heartbeat'));
-	}
+		/**
+		 * Testing the router is tricky because the routing files are loaded with include_once:
+		 * https://github.com/nextcloud/server/blob/b97c7dfe7f162680ffd9720ece12cdcd3ab656cd/lib/private/Route/Router.php#L461-L469
+		 *
+		 * It's not possible to create multiple router instances because a second instance won't find the routes
+		 * because the appinfo/routes.php files aren't included because they were included by the previous one.
+		 */
 
-	public function testGenerateConsecutively(): void {
+		$this->assertEquals('/index.php/heartbeat', $router->generate('heartbeat'));
 
-		$this->assertEquals('/index.php/apps/files/', $this->router->generate('files.view.index'));
+		$this->assertEquals('/index.php/apps/files/', $router->generate('files.view.index'));
 
 		// the OCS route is the prefixed one for the AppFramework - see /ocs/v1.php for routing details
-		$this->assertEquals('/index.php/ocsapp/apps/dav/api/v1/direct', $this->router->generate('ocs.dav.direct.getUrl'));
+		$this->assertEquals('/index.php/ocsapp/apps/dav/api/v1/direct', $router->generate('ocs.dav.direct.getUrl'));
 
 		// test caching
-		$this->assertEquals('/index.php/apps/files/', $this->router->generate('files.view.index'));
+		$this->assertEquals('/index.php/apps/files/', $router->generate('files.view.index'));
 	}
 }