Merge pull request #54689 from nextcloud/bugfix/noid/fix-missing-return-type

Author: provokateurin

lib/public/Comments/ICommentsManager.php

@@ -181,7 +181,7 @@ public function searchForObjects(string $search, string $objectType, array $obje
 	 * @param \DateTime|null $notOlderThan optional, timestamp of the oldest comments
 	 *                                     that may be returned
 	 * @param string $verb Limit the verb of the comment - Added in 14.0.0
-	 * @return Int
+	 * @return int
 	 * @since 9.0.0
 	 */
 	public function getNumberOfCommentsForObject($objectType, $objectId, ?\DateTime $notOlderThan = null, $verb = '');
@@ -195,7 +195,7 @@ public function getNumberOfCommentsForObject($objectType, $objectId, ?\DateTime
 	 * @return array<string, int>
 	 * @since 32.0.0
 	 */
-	public function getNumberOfCommentsForObjects(string $objectType, array $objectIds, ?\DateTime $notOlderThan = null, string $verb = '');
+	public function getNumberOfCommentsForObjects(string $objectType, array $objectIds, ?\DateTime $notOlderThan = null, string $verb = ''): array;
 
 	/**
 	 * @param string $objectType the object type, e.g. 'files'

tests/lib/Comments/FakeManager.php

@@ -56,10 +56,10 @@ public function getCommentsWithVerbForObjectSinceComment(
 		return [];
 	}
 
-	public function getNumberOfCommentsForObject($objectType, $objectId, ?\DateTime $notOlderThan = null, $verb = '') {
+	public function getNumberOfCommentsForObject($objectType, $objectId, ?\DateTime $notOlderThan = null, $verb = ''): int {
 	}
 
-	public function getNumberOfCommentsForObjects(string $objectType, array $objectIds, ?\DateTime $notOlderThan = null, string $verb = '') :array {
+	public function getNumberOfCommentsForObjects(string $objectType, array $objectIds, ?\DateTime $notOlderThan = null, string $verb = ''): array {
 		return array_fill_keys($objectIds, 0);
 	}