Merge pull request #10227 from nextcloud/bugfix/10160/ldap-bind-loop

Only bind to ldap if configuration for the first server is set

Author: MorrisJobke

apps/user_ldap/lib/Connection.php

@@ -576,8 +576,8 @@ private function establishConnection() {
 				if (!$isOverrideMainServer) {
 					$this->doConnect($this->configuration->ldapHost,
 						$this->configuration->ldapPort);
+					return $this->bind();
 				}
-				return $this->bind();
 			} catch (ServerNotAvailableException $e) {
 				if(!$isBackupHost) {
 					throw $e;

apps/user_ldap/tests/ConnectionTest.php

@@ -110,7 +110,7 @@ public function testUseBackupServer() {
 			->method('setOption')
 			->will($this->returnValue(true));
 
-		$this->ldap->expects($this->exactly(2))
+		$this->ldap->expects($this->exactly(3))
 			->method('connect')
 			->will($this->returnValue('ldapResource'));
 
@@ -119,7 +119,7 @@ public function testUseBackupServer() {
 			->will($this->returnValue(0));
 
 		// Not called often enough? Then, the fallback to the backup server is broken.
-		$this->connection->expects($this->exactly(3))
+		$this->connection->expects($this->exactly(4))
 			->method('getFromCache')
 			->with('overrideMainServer')
 			->will($this->onConsecutiveCalls(false, false, true, true));