Support strict typing in NC14 for IRequest::getHeader()

(nextcloud/server/pull/7813)

Author: LEDfan

lib/Middleware/ExternalApiMiddleware.php

@@ -37,7 +37,7 @@ public function beforeController($controller, $methodName)
 		$jsxcSignatureHeader = $this->request->getHeader('X-JSXC-SIGNATURE');
 
 		// check if we have a signature
-		if (! isset($jsxcSignatureHeader)) {
+		if ($jsxcSignatureHeader === '' || is_null($jsxcSignatureHeader)) {
 			throw new SecurityException('HTTP header "X-JSXC-Signature" is missing.');
 		} elseif (! extension_loaded('hash')) {
 			throw new SecurityException('Missing "hash" extension to check the secret code validity.');

tests/unit/Middleware/ExternalApiMiddlewareTest.php

@@ -49,7 +49,7 @@ public function testBeforeControllerWithoutHeader()
 			   ->expects($this->once())
 			   ->method('getHeader')
 			   ->with('X-JSXC-SIGNATURE')
-			   ->willReturn(null);
+			   ->willReturn('');
 
 		$this->expectException(SecurityException::class);
 		$this->expectExceptionMessage('HTTP header "X-JSXC-Signature" is missing.');