Skip to content

Commit 655c4ed

Browse files
committed
fix: Bind all generic question listeners to reduce boilerplate code
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
1 parent c536513 commit 655c4ed

5 files changed

Lines changed: 5 additions & 25 deletions

File tree

src/components/Questions/QuestionDate.vue

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,7 @@
3131
:max-string-lengths="maxStringLengths"
3232
:title-placeholder="answerType.titlePlaceholder"
3333
:warning-invalid="answerType.warningInvalid"
34-
@update:text="onTitleChange"
35-
@update:description="onDescriptionChange"
36-
@update:isRequired="onRequiredChange"
37-
@update:name="onNameChange"
38-
@delete="onDelete">
34+
v-on="commonListeners">
3935
<div class="question__content">
4036
<NcDatetimePicker v-model="time"
4137
:disabled="!readOnly"

src/components/Questions/QuestionDropdown.vue

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,7 @@
3333
:warning-invalid="answerType.warningInvalid"
3434
:content-valid="contentValid"
3535
:shift-drag-handle="shiftDragHandle"
36-
@update:text="onTitleChange"
37-
@update:description="onDescriptionChange"
38-
@update:isRequired="onRequiredChange"
39-
@update:name="onNameChange"
40-
@delete="onDelete">
36+
v-on="commonListeners">
4137
<template #actions>
4238
<NcActionCheckbox :checked="extraSettings?.shuffleOptions"
4339
@update:checked="onShuffleOptionsChange">

src/components/Questions/QuestionLong.vue

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,7 @@
3131
:max-string-lengths="maxStringLengths"
3232
:title-placeholder="answerType.titlePlaceholder"
3333
:warning-invalid="answerType.warningInvalid"
34-
@update:text="onTitleChange"
35-
@update:description="onDescriptionChange"
36-
@update:isRequired="onRequiredChange"
37-
@update:name="onNameChange"
38-
@delete="onDelete">
34+
v-on="commonListeners">
3935
<div class="question__content">
4036
<textarea ref="textarea"
4137
:aria-label="t('forms', 'A long answer for the question “{text}”', { text })"

src/components/Questions/QuestionMultiple.vue

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,7 @@
3333
:warning-invalid="answerType.warningInvalid"
3434
:content-valid="contentValid"
3535
:shift-drag-handle="shiftDragHandle"
36-
@update:text="onTitleChange"
37-
@update:description="onDescriptionChange"
38-
@update:isRequired="onRequiredChange"
39-
@update:name="onNameChange"
40-
@delete="onDelete">
36+
v-on="commonListeners">
4137
<template #actions>
4238
<NcActionCheckbox :checked="extraSettings?.shuffleOptions"
4339
@update:checked="onShuffleOptionsChange">

src/components/Questions/QuestionShort.vue

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,7 @@
3131
:max-string-lengths="maxStringLengths"
3232
:title-placeholder="answerType.titlePlaceholder"
3333
:warning-invalid="answerType.warningInvalid"
34-
@update:text="onTitleChange"
35-
@update:description="onDescriptionChange"
36-
@update:isRequired="onRequiredChange"
37-
@update:name="onNameChange"
38-
@delete="onDelete">
34+
v-on="commonListeners">
3935
<div class="question__content">
4036
<input ref="input"
4137
:aria-label="t('forms', 'A short answer for the question “{text}”', { text })"

0 commit comments

Comments
 (0)