fix(attachments): check for editorApi attachments support

Signed-off-by: Jonas <jonas@freesources.org>

Author: mejo-

cypress/e2e/page-attachments.js

@@ -42,8 +42,12 @@ describe('Page attachments', function() {
 		// Open attachment list
 		cy.get('button.app-sidebar__toggle').click()
 
-		cy.get('.attachment-list-embedded').should('contain', 'test.png')
-		cy.get('.attachment-list-not-embedded').should('not.exist')
+		if (['stable31'].includes(Cypress.env('ncVersion'))) {
+			cy.get('.attachment-list-not-embedded').should('contain', 'test.png')
+		} else {
+			cy.get('.attachment-list-embedded').should('contain', 'test.png')
+			cy.get('.attachment-list-not-embedded').should('not.exist')
+		}
 
 		// Close sidebar
 		cy.get('button.app-sidebar__close').click({ force: true })
@@ -57,8 +61,12 @@ describe('Page attachments', function() {
 		// Open attachment list
 		cy.get('button.app-sidebar__toggle').click()
 
-		cy.get('.attachment-list-embedded').should('contain', 'test.png')
-		cy.get('.attachment-list-not-embedded').should('not.exist')
+		if (['stable31'].includes(Cypress.env('ncVersion'))) {
+			cy.get('.attachment-list-not-embedded').should('contain', 'test.png')
+		} else {
+			cy.get('.attachment-list-embedded').should('contain', 'test.png')
+			cy.get('.attachment-list-not-embedded').should('not.exist')
+		}
 
 		// Delete image from editor
 		cy.getEditor()

src/components/PageSidebar/AttachmentItem.vue

@@ -39,7 +39,7 @@
 				{{ t('collectives', 'View in page') }}
 			</NcActionButton>
 			<NcActionButton
-				v-if="!isEmbedded && !isDeleted && !isInFolder && isTextEdit && currentCollectiveCanEdit"
+				v-if="!isEmbedded && !isDeleted && !isInFolder && editorApiAttachments && isTextEdit && currentCollectiveCanEdit"
 				:close-after-click="true"
 				@click="onInsert">
 				<template #icon>
@@ -118,6 +118,7 @@ import PencilOutlineIcon from 'vue-material-design-icons/PencilOutline.vue'
 import RestoreIcon from 'vue-material-design-icons/Restore.vue'
 import DownloadIcon from 'vue-material-design-icons/TrayArrowDown.vue'
 import { useNetworkState } from '../../composables/useNetworkState.ts'
+import { editorApiAttachments } from '../../constants.js'
 import { useCollectivesStore } from '../../stores/collectives.js'
 import { usePagesStore } from '../../stores/pages.js'
 import { useRootStore } from '../../stores/root.js'
@@ -164,6 +165,7 @@ export default {
 
 	computed: {
 		...mapState(useRootStore, [
+			'editorApiFlags',
 			'isPublic',
 			'shareTokenParam',
 		]),
@@ -175,6 +177,10 @@ export default {
 			'isTextEdit',
 		]),
 
+		editorApiAttachments() {
+			return this.editorApiFlags.includes(editorApiAttachments)
+		},
+
 		isInFolder() {
 			return this.attachment.type === 'folder'
 		},

src/components/PageSidebar/SidebarTabAttachments.vue

@@ -76,7 +76,7 @@
 
 				<!-- text attachments not in page list -->
 				<div v-if="notEmbeddedAttachments.length">
-					<div class="attachment-list-subheading">
+					<div v-if="editorApiAttachments" class="attachment-list-subheading">
 						<div>
 							{{ t('collectives', 'Not in page') }}
 						</div>
@@ -174,6 +174,7 @@ import AttachmentItem from './AttachmentItem.vue'
 import AttachmentRenameDialog from './AttachmentRenameDialog.vue'
 import OfflineContent from './OfflineContent.vue'
 import { useNetworkState } from '../../composables/useNetworkState.ts'
+import { editorApiAttachments } from '../../constants.js'
 import { useCollectivesStore } from '../../stores/collectives.js'
 import { usePagesStore } from '../../stores/pages.js'
 import { useRootStore } from '../../stores/root.js'
@@ -210,7 +211,7 @@ export default {
 	},
 
 	computed: {
-		...mapState(useRootStore, ['loading']),
+		...mapState(useRootStore, ['editorApiFlags', 'loading']),
 
 		...mapState(useCollectivesStore, ['currentCollectiveCanEdit']),
 
@@ -224,6 +225,10 @@ export default {
 			'deletedAttachments',
 		]),
 
+		editorApiAttachments() {
+			return this.editorApiFlags.includes(editorApiAttachments)
+		},
+
 		noAttachmentsDescription() {
 			return t('collectives', 'Add attachments using drag and drop or via "Insert attachment" in the formatting menu.')
 		},

src/constants.js

@@ -47,5 +47,6 @@ export const pageModes = {
 
 export const editorApiReaderFileId = 'READER_FILE_ID'
 export const editorApiUpdateReadonlyBarProps = 'UPDATE_READONLY_BAR_PROPS'
+export const editorApiAttachments = 'ATTACHMENTS'
 
 export const sessionUpdateInterval = 90 // in seconds

src/stores/root.js

@@ -6,7 +6,7 @@
 import { useLocalStorage } from '@vueuse/core'
 import { defineStore } from 'pinia'
 import { set } from 'vue'
-import { editorApiReaderFileId, editorApiUpdateReadonlyBarProps } from '../constants.js'
+import { editorApiReaderFileId, editorApiUpdateReadonlyBarProps, editorApiAttachments } from '../constants.js'
 
 const STORE_PREFIX = 'collectives/pinia/root/'
 
@@ -44,6 +44,9 @@ export const useRootStore = defineStore('root', {
 			if (this.editorApiVersionCheck('1.2')) {
 				flags.push(editorApiUpdateReadonlyBarProps)
 			}
+			if (this.editorApiVersionCheck('1.4')) {
+				flags.push(editorApiAttachments)
+			}
 			return flags
 		},
 	},