Skip to content

Commit d586a61

Browse files
committed
add polling for task selection
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
1 parent 7f07fad commit d586a61

3 files changed

Lines changed: 14 additions & 4 deletions

File tree

app/src/main/java/com/nextcloud/client/assistant/AssistantViewModel.kt

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,6 @@ class AssistantViewModel(
238238
val result = remoteRepository.translate(input, taskType)
239239
if (result.isSuccess) {
240240
_isTranslationTaskCreated.update { true }
241-
// TODO: Select newly created translation task
242241

243242
val selectedTaskId = selectedTask.value?.id ?: return@launch
244243

@@ -420,6 +419,14 @@ class AssistantViewModel(
420419
}
421420

422421
fun selectTask(task: Task?) {
422+
viewModelScope.launch {
423+
if (task?.isTranslate() == true) {
424+
_selectedTaskType.value?.let {
425+
pollTranslationResult(it, task.id)
426+
}
427+
}
428+
}
429+
423430
selectedTask.update {
424431
task
425432
}

app/src/main/java/com/nextcloud/client/assistant/translate/TranslationScreen.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,7 @@ fun TranslationScreen(
109109
.padding(16.dp)
110110
.padding(top = 32.dp),
111111
floatingActionButton = {
112-
if (!isTaskExists) {
113-
// TODO: After first task creation dont allow user to create another back to back
112+
if (!isTaskExists && !isTranslationTaskCreated) {
114113
FloatingActionButton(onClick = {
115114
val originLang = sourceState.language
116115
val targetLang = targetState.language

app/src/main/res/values/strings.xml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,14 @@
8181
<string name="assistant_task_status_failed">failed</string>
8282

8383
<!-- Translation Screen -->
84+
<string name="assistant_screen_select_task">Please select task</string>
8485
<string name="translation_screen_label_from">Translate from: </string>
8586
<string name="translation_screen_label_to">Translate to: </string>
87+
<string name="translation_screen_translating">Translating…</string>
88+
<string name="translation_screen_start_to_translate_task">Press the button to translate</string>
8689
<string name="translation_screen_hint_source">Enter text to translate…</string>
87-
<string name="translation_screen_hint_target">Translation will appear here…</string>
90+
<string name="translation_screen_error_message">Translation model not exists.</string>
91+
<string name="translation_screen_task_processing">Translation is taking longer than expected.</string>
8892

8993
<!-- Conversation Screen -->
9094
<string name="conversation_screen_title">Conversations</string>

0 commit comments

Comments
 (0)