Skip to content

chore: fix typo#315

Merged
ihrpr merged 2 commits into
modelcontextprotocol:mainfrom
Skn0tt:patch-1
May 24, 2025
Merged

chore: fix typo#315
ihrpr merged 2 commits into
modelcontextprotocol:mainfrom
Skn0tt:patch-1

Conversation

@Skn0tt

@Skn0tt Skn0tt commented Apr 11, 2025

Copy link
Copy Markdown
Contributor

Fixes small typo from #247.

Pizzaface pushed a commit to RewstApp/mcp-inspector that referenced this pull request May 2, 2025
* Remove bin folder, leaving cli, server, and client
* This fixes modelcontextprotocol#315
* In .gitignore,
  - add .idea
  - remove bin/build
* Remove bin and bin/cli.js
* Remove bin/scripts/copy-cli.js
* Refactor/move bin/scripts to cli/scripts
* Refactor/move bin/src/index.ts to cli/src/cli.ts
* Refactor/renamed client/bin/cli.js to client/bin/client.js
* In .github/workflows/main.yml,
  - add run of cli tests
* In cli/pacakge.json
  - change main and bin/mcp-inspector-cli properties to build/cli.js
* In client/package.json,
  - change bin/mcp-inspector-client properties to build/start.js
* In pacakge.json
  - change bin/mcp-inspector property to ./cli/build/cli.js
  - removed bin and cli/bin from files list
  - removed @modelcontextprotocol/inspector-bin dependency
  - rearranged and corrected scripts
@mdarveau

mdarveau commented May 6, 2025

Copy link
Copy Markdown

I think it should be { permission: z.enum(["write", "admin"])},

@Skn0tt

Skn0tt commented May 6, 2025

Copy link
Copy Markdown
Contributor Author

I agree!

@Skn0tt

Skn0tt commented May 6, 2025

Copy link
Copy Markdown
Contributor Author

cc @geelen @jspahrsummers

@geelen

geelen commented May 7, 2025

Copy link
Copy Markdown
Contributor

Ha, that's my mistake. I don't have approve/merge permissions so will let Justin hit the button. Thanks

@ihrpr

ihrpr commented May 24, 2025

Copy link
Copy Markdown
Contributor

Thank you!

@ihrpr ihrpr merged commit d5c996b into modelcontextprotocol:main May 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants