diff --git a/src/lib/github-auth.ts b/src/lib/github-auth.ts index 23d7921..2810e51 100644 --- a/src/lib/github-auth.ts +++ b/src/lib/github-auth.ts @@ -1,2 +1,13 @@ -/** GitHub authentication and pagination exports. */ -export * from "./github"; +/** + * GitHub authentication and pagination facade — intentionally empty. + * + * This facade was introduced as part of #618 (split `github.ts` into domain + * modules) but was closed as declined by #655. The facades added no value + * beyond re-exporting from `./github`, so they have been left as empty + * modules to preserve the public module surface and the file's role as a + * documented split point, without the misleading `export *` re-export. + * + * Callers should import directly from `@/lib/github`. See #655 for the + * reconciliation decision. + */ +export {}; diff --git a/src/lib/github-ci.ts b/src/lib/github-ci.ts index 8217a68..7c01a0f 100644 --- a/src/lib/github-ci.ts +++ b/src/lib/github-ci.ts @@ -1,2 +1,14 @@ -/** GitHub Actions and CI exports. */ -export * from "./github"; +/** + * GitHub CI (workflows, runs, jobs, releases, packages, metadata) facade — + * intentionally empty. + * + * This facade was introduced as part of #618 (split `github.ts` into domain + * modules) but was closed as declined by #655. The facades added no value + * beyond re-exporting from `./github`, so they have been left as empty + * modules to preserve the public module surface and the file's role as a + * documented split point, without the misleading `export *` re-export. + * + * Callers should import directly from `@/lib/github`. See #655 for the + * reconciliation decision. + */ +export {}; diff --git a/src/lib/github-code-search.ts b/src/lib/github-code-search.ts index 9661266..3be61df 100644 --- a/src/lib/github-code-search.ts +++ b/src/lib/github-code-search.ts @@ -1,2 +1,14 @@ -/** GitHub code-search exports. */ -export * from "./github"; +/** + * GitHub code search and discussion / membership helpers facade — intentionally + * empty. + * + * This facade was introduced as part of #618 (split `github.ts` into domain + * modules) but was closed as declined by #655. The facades added no value + * beyond re-exporting from `./github`, so they have been left as empty + * modules to preserve the public module surface and the file's role as a + * documented split point, without the misleading `export *` re-export. + * + * Callers should import directly from `@/lib/github`. See #655 for the + * reconciliation decision. + */ +export {}; diff --git a/src/lib/github-facades.test.ts b/src/lib/github-facades.test.ts new file mode 100644 index 0000000..767d198 --- /dev/null +++ b/src/lib/github-facades.test.ts @@ -0,0 +1,22 @@ +// @vitest-environment node +// Regression test for #655: the four domain facades introduced by #618 must +// remain intentionally empty and must not re-export from `./github`. See +// #655 for the reconciliation decision. +import { describe, expect, it } from "vitest"; +import * as Auth from "./github-auth"; +import * as Ci from "./github-ci"; +import * as CodeSearch from "./github-code-search"; +import * as Issues from "./github-issues"; + +describe("github domain facades (regression for #655)", () => { + const facades = [ + ["github-auth", Auth], + ["github-ci", Ci], + ["github-code-search", CodeSearch], + ["github-issues", Issues], + ] as const; + + it.each(facades)("%s has no named exports", (_name, mod) => { + expect(Object.keys(mod).sort()).toEqual([]); + }); +}); diff --git a/src/lib/github-issues.ts b/src/lib/github-issues.ts index c7ee51b..6d5150e 100644 --- a/src/lib/github-issues.ts +++ b/src/lib/github-issues.ts @@ -1,2 +1,13 @@ -/** GitHub issue and pull-request exports. */ -export * from "./github"; +/** + * GitHub issues, pull requests and review helpers facade — intentionally empty. + * + * This facade was introduced as part of #618 (split `github.ts` into domain + * modules) but was closed as declined by #655. The facades added no value + * beyond re-exporting from `./github`, so they have been left as empty + * modules to preserve the public module surface and the file's role as a + * documented split point, without the misleading `export *` re-export. + * + * Callers should import directly from `@/lib/github`. See #655 for the + * reconciliation decision. + */ +export {}; diff --git a/src/lib/github.ts b/src/lib/github.ts index 35e94aa..c78c3d7 100644 --- a/src/lib/github.ts +++ b/src/lib/github.ts @@ -1,3 +1,14 @@ +/** + * GitHub REST + GraphQL client wrapper. + * + * Size note: this file is intentionally kept as a single ~1000-line module + * rather than split by domain (auth / issues / CI / code-search). The split + * proposed in #618 was closed as declined by #655 after review showed the + * domain facades added no value beyond `export * from "./github"`. See the + * sibling facade files (`./github-auth`, `./github-ci`, + * `./github-code-search`, `./github-issues`) for the documented split points + * and #655 for the reconciliation decision. + */ import { GitHubIssue } from "@/types"; import type { CheckFailure, PrHealthInput } from "./linked-pr-health";