Skip to content

Enabled windows ProcessorAffinity support #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RakeshwarK wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Enabled windows ProcessorAffinity support #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b52b578
Init Commit
Jan 14, 2026
e38b7c3
Update tests
Jan 15, 2026
0d2e6b1
Merge branch 'main' into cpuAffinity
RakeshwarK Jan 15, 2026
3204568
Merge branch 'microsoft:main' into cpuAffinity
RakeshwarK Jan 16, 2026
cc25f56
Update tests
Jan 16, 2026
55cd743
Merge branch 'main' into cpuAffinity
RakeshwarK Jan 22, 2026
f54ea20
commit changes
Jan 22, 2026
d0d07e8
Merge branch 'cpuAffinity' of https://github.com/RakeshwarK/VirtualCl…
Jan 22, 2026
d95fe15
Merge branch 'microsoft:main' into cpuAffinity
RakeshwarK Jan 28, 2026
0d259aa
Merge branch 'microsoft:main' into cpuAffinity
RakeshwarK Jan 29, 2026
ff91e6f
Windows Changes
Jan 29, 2026
1042592
Merge branch 'cpuAffinity' of https://github.com/RakeshwarK/VirtualCl…
Jan 29, 2026
7e027fe
Added Doccu
Jan 29, 2026
8a33af1
Format Doc
Jan 29, 2026
09e1508
Update profile
Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
178 changes: 178 additions & 0 deletions ...alClient/VirtualClient.Actions.FunctionalTests/ExampleWorkloadWithAffinityProfileTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,178 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

namespace VirtualClient.Actions
{
using System;
using System.Collections.Generic;
using System.Linq;
using System.Runtime.InteropServices;
using System.Threading;
using System.Threading.Tasks;
using NUnit.Framework;
using VirtualClient.Common;
using VirtualClient.Contracts;

[TestFixture]
[Category("Functional")]
public class ExampleWorkloadWithAffinityProfileTests
{
private DependencyFixture mockFixture;

[OneTimeSetUp]
public void SetupFixture()
{
this.mockFixture = new DependencyFixture();
ComponentTypeCache.Instance.LoadComponentTypes(TestDependencies.TestDirectory);
}

[Test]
[TestCase("PERF-CPU-EXAMPLE-AFFINITY.json", PlatformID.Unix, Architecture.X64)]
[TestCase("PERF-CPU-EXAMPLE-AFFINITY.json", PlatformID.Unix, Architecture.Arm64)]
public void ExampleWorkloadProfileParametersAreInlinedCorrectly_Linux(string profile, PlatformID platform, Architecture architecture)
{
this.mockFixture.Setup(platform, architecture);
using (ProfileExecutor executor = TestDependencies.CreateProfileExecutor(profile, this.mockFixture.Dependencies))
{
WorkloadAssert.ParameterReferencesInlined(executor.Profile);
}
}

[Test]
[Platform(Exclude = "Unix,Linux,MacOsX")]
[TestCase("PERF-CPU-EXAMPLE-AFFINITY.json", PlatformID.Win32NT, Architecture.X64)]
[TestCase("PERF-CPU-EXAMPLE-AFFINITY.json", PlatformID.Win32NT, Architecture.Arm64)]
public void ExampleWorkloadProfileParametersAreInlinedCorrectly_Windows(string profile, PlatformID platform, Architecture architecture)
{
this.mockFixture.Setup(platform, architecture);
using (ProfileExecutor executor = TestDependencies.CreateProfileExecutor(profile, this.mockFixture.Dependencies))
{
WorkloadAssert.ParameterReferencesInlined(executor.Profile);
}
}

[Test]
[TestCase("PERF-CPU-EXAMPLE-AFFINITY.json", PlatformID.Unix)]
public async Task ExampleWorkloadProfileInstallsTheExpectedDependenciesOnLinuxPlatform(string profile, PlatformID platform)
{
this.mockFixture.Setup(platform);

using (ProfileExecutor executor = TestDependencies.CreateProfileExecutor(profile, this.mockFixture.Dependencies, dependenciesOnly: true))
{
await executor.ExecuteAsync(ProfileTiming.OneIteration(), CancellationToken.None).ConfigureAwait(false);

// Workload dependency package should be installed
WorkloadAssert.WorkloadPackageInstalled(this.mockFixture, "exampleworkload");
}
}

[Test]
[Platform(Exclude = "Unix,Linux,MacOsX")]
[TestCase("PERF-CPU-EXAMPLE-AFFINITY.json", PlatformID.Win32NT)]
public async Task ExampleWorkloadProfileInstallsTheExpectedDependenciesOnWindowsPlatform(string profile, PlatformID platform)
{
this.mockFixture.Setup(platform);

using (ProfileExecutor executor = TestDependencies.CreateProfileExecutor(profile, this.mockFixture.Dependencies, dependenciesOnly: true))
{
await executor.ExecuteAsync(ProfileTiming.OneIteration(), CancellationToken.None).ConfigureAwait(false);

// Workload dependency package should be installed
WorkloadAssert.WorkloadPackageInstalled(this.mockFixture, "exampleworkload");
}
}

[Test]
[TestCase("PERF-CPU-EXAMPLE-AFFINITY.json", PlatformID.Unix)]
public async Task ExampleWorkloadProfileExecutesTheExpectedWorkloadWithAffinityOnLinux(string profile, PlatformID platform)
{
this.mockFixture.Setup(platform);
this.mockFixture.SetupPackage("exampleworkload", expectedFiles: "linux-x64/ExampleWorkload");

this.mockFixture.ProcessManager.OnCreateProcess = (command, arguments, workingDir) =>
{
IProcessProxy process = this.mockFixture.CreateProcess(command, arguments, workingDir);
if (command.Contains("bash") && arguments.Contains("numactl"))
{
// Verify numactl wrapper is used for CPU affinity on Linux
process.StandardOutput.Append("{ \"metric1\": 100, \"metric2\": 200 }");
}

return process;
};

using (ProfileExecutor executor = TestDependencies.CreateProfileExecutor(profile, this.mockFixture.Dependencies))
{
await executor.ExecuteAsync(ProfileTiming.OneIteration(), CancellationToken.None).ConfigureAwait(false);

// Verify numactl was used for CPU affinity
WorkloadAssert.CommandsExecuted(this.mockFixture, "\"numactl -C");
}
}

[Test]
[Platform(Exclude = "Unix,Linux,MacOsX")]
[TestCase("PERF-CPU-EXAMPLE-AFFINITY.json", PlatformID.Win32NT)]
public async Task ExampleWorkloadProfileExecutesTheExpectedWorkloadWithAffinityOnWindows(string profile, PlatformID platform)
{
this.mockFixture.Setup(platform);
this.mockFixture.SetupPackage("exampleworkload", expectedFiles: "win-x64/ExampleWorkload.exe");

this.mockFixture.ProcessManager.OnCreateProcess = (command, arguments, workingDir) =>
{
InMemoryProcess process = this.mockFixture.CreateProcess(command, arguments, workingDir);
if (command.Contains("ExampleWorkload"))
{
// Set HasExited to false initially, true after "wait"
bool hasExited = false;
process.OnHasExited = () => hasExited;
process.OnStart = () =>
{
hasExited = false;
return true;
};

process.OnApplyAffinity = (mask) =>
{
// Verify affinity mask is set while process is running
Assert.IsFalse(hasExited, "Affinity should be applied while process is running");
Assert.Greater(mask.ToInt64(), 0);
};

// Simulate process completion when WaitForExitAsync is called
Task originalWait = process.WaitForExitAsync(CancellationToken.None);
process.StandardOutput.Append("{ \"metric1\": 100, \"metric2\": 200 }");
hasExited = true;
}

return process;
};

using (ProfileExecutor executor = TestDependencies.CreateProfileExecutor(profile, this.mockFixture.Dependencies))
{
await executor.ExecuteAsync(ProfileTiming.OneIteration(), CancellationToken.None).ConfigureAwait(false);

// Verify the process was executed
WorkloadAssert.CommandsExecuted(this.mockFixture, "ExampleWorkload");
}
}

[Test]
[TestCase("PERF-CPU-EXAMPLE-AFFINITY.json")]
public void ExampleWorkloadProfileActionsWillNotBeExecutedIfTheWorkloadPackageDoesNotExist(string profile)
{
this.mockFixture.Setup(PlatformID.Unix);

// Ensure the workload package does not exist
this.mockFixture.PackageManager.Clear();

using (ProfileExecutor executor = TestDependencies.CreateProfileExecutor(profile, this.mockFixture.Dependencies))
{
executor.ExecuteDependencies = false;

DependencyException error = Assert.ThrowsAsync<DependencyException>(() => executor.ExecuteAsync(ProfileTiming.OneIteration(), CancellationToken.None));
Assert.AreEqual(ErrorReason.WorkloadDependencyMissing, error.Reason);
}
}
}
}
Loading
Loading