From e2f15abe006243e97f6b1ad50af2685b8927c275 Mon Sep 17 00:00:00 2001 From: Copilot <223556219+Copilot@users.noreply.github.com> Date: Thu, 4 Jun 2026 08:46:25 -0700 Subject: [PATCH] MAINT: suppress ty missing-override-decorator rule PR #1919 bumped allganize/ty-pre-commit from v0.0.32 to v0.0.43. The newer ty release activated the missing-override-decorator rule, which under the existing `[tool.ty.rules] all = "error"` config produced 735 hard CI errors across pyrit/ (287 files) and turned main RED. Adopting `@override` everywhere would require `typing_extensions` (`typing.override` is 3.12+, PyRIT supports 3.10+), adding a new direct runtime dependency plus the ongoing import-path footgun of contributors copying `from typing import override` from 3.12-only examples. Suppressing the rule is consistent with the file's other pragmatic ignores (`unresolved-import`, `possibly-missing-attribute`, `empty-body`) and keeps the project mergeable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- pyproject.toml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pyproject.toml b/pyproject.toml index 2304040168..ee6ef1b728 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -179,6 +179,12 @@ unused-ignore-comment = "warn" unused-type-ignore-comment = "warn" # Allow empty function bodies during development empty-body = "ignore" +# ty 0.0.43 (bumped from 0.0.32 in #1919) activated this rule under +# [tool.ty.rules] all = "error". Adopting @override across pyrit/ would require +# the typing_extensions backport on Python 3.10/3.11 (typing.override is 3.12+), +# which adds a direct dep and ongoing import-path friction. Suppressing the +# rule keeps the codebase consistent with the existing pragmatic ignores above. +missing-override-decorator = "ignore" [tool.ty.analysis] respect-type-ignore-comments = true