Skip to content

Commit 1b6376f

Browse files
committed
feat: upgrade deps
1 parent 6dd2009 commit 1b6376f

File tree

4 files changed

+2210
-2623
lines changed

4 files changed

+2210
-2623
lines changed

__tests__/integration.spec.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ describe('integration tests', () => {
4444
}
4545
}
4646

47-
function isLockAcquisitionError(e: Error): e is LockAcquisitionError {
48-
return e.name === 'LockAcquisitionError'
47+
function isLockAcquisitionError(e: unknown): e is LockAcquisitionError {
48+
return e instanceof Error && e.name === 'LockAcquisitionError'
4949
}
5050

5151
beforeEach(async () => {
@@ -266,7 +266,7 @@ describe('integration tests', () => {
266266
try {
267267
const result = await queueManager.dlock.fanout(id, 1500, job, arg1)
268268
onComplete(result)
269-
} catch (e) {
269+
} catch (e: any) {
270270
if (e.message === 'queue-no-response') {
271271
timeoutError(e)
272272
} else {
@@ -303,7 +303,7 @@ describe('integration tests', () => {
303303
try {
304304
const result = await queueManager.dlock.fanout(id, 1500, job)
305305
onComplete(result)
306-
} catch (e) {
306+
} catch (e: any) {
307307
if (e.message === 'queue-no-response') {
308308
timeoutError(e)
309309
} else {
@@ -331,7 +331,7 @@ describe('integration tests', () => {
331331
try {
332332
const results = await queueManager.dlock.fanout('error', job)
333333
onComplete(null, results)
334-
} catch (e) {
334+
} catch (e: any) {
335335
if (e.name === args.name && e.message === args.message) {
336336
onComplete(e)
337337
} else {

package.json

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -41,32 +41,31 @@
4141
"@microfleet/callback-queue": "^4.0.2",
4242
"@microfleet/ioredis-lock": "^5.0.4",
4343
"bluebird": "^3.7.1",
44-
"denque": "^1.5.0",
44+
"denque": "^2.0.1",
4545
"lodash": "^4.17.21",
46-
"pino": "^6.11.3",
46+
"pino": "^7.2.0",
4747
"read-pkg-up": "7",
4848
"serialize-error": "^8.1.0"
4949
},
5050
"devDependencies": {
5151
"@makeomatic/deploy": "^10.4.0",
5252
"@types/bluebird": "^3.5.33",
5353
"@types/ioredis": "^4.22.3",
54-
"@types/jest": "^26.0.22",
54+
"@types/jest": "^27.0.2",
5555
"@types/lodash": "^4.14.168",
56-
"@types/node": "^14.14.41",
57-
"@types/pino": "^6.3.7",
56+
"@types/node": "^16.11.7",
5857
"@types/sinon": "^10.0.0",
59-
"@typescript-eslint/eslint-plugin": "^4.22.0",
60-
"@typescript-eslint/parser": "^4.22.0",
58+
"@typescript-eslint/eslint-plugin": "^5.4.0",
59+
"@typescript-eslint/parser": "^5.4.0",
6160
"cross-env": "^7.0.3",
62-
"eslint": "^7.24.0",
61+
"eslint": "^8.2.0",
6362
"eslint-config-makeomatic": "^5.0.4",
6463
"eslint-plugin-import": "^2.22.1",
6564
"eslint-plugin-promise": "^5.1.0",
6665
"ioredis": "^4.26.0",
67-
"jest": "^26.6.3",
68-
"sinon": "^10.0.0",
69-
"ts-jest": "^26.5.5",
66+
"jest": "^27.3.1",
67+
"sinon": "^12.0.1",
68+
"ts-jest": "^27.0.7",
7069
"typescript": "^4.2.4"
7170
},
7271
"engine": {

src/distributed-callback-queue.ts

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import Bluebird = require('bluebird')
22
import redislock = require('@microfleet/ioredis-lock')
33
import Redis = require('ioredis')
4-
import pino = require('pino')
4+
import { pino } from 'pino'
55
import assert = require('assert')
66
import readPkg = require('read-pkg-up')
77

@@ -15,15 +15,14 @@ import compose = require('lodash/fp/compose')
1515
import * as callbackQueue from './callback-queue'
1616
import { Semaphore } from './semaphore'
1717
import { MultiLock, MultiLockError } from './multi-lock'
18-
import P = require('pino')
1918
import { Thunk } from '@microfleet/callback-queue'
2019

2120
const { LockAcquisitionError } = redislock
2221
const isBoolean = filter<string>(Boolean)
2322
const toFlattenedTruthyArray = compose(isBoolean, flatten)
2423
const couldNotAcquireLockError = new LockAcquisitionError('job is already running')
2524
const TimeoutError = new Bluebird.TimeoutError('queue-no-response')
26-
const notLockAcquisitionError = (e: Error) => e.name !== 'LockAcquisitionError'
25+
const notLockAcquisitionError = (e: unknown): e is Error => e instanceof Error && e.name !== 'LockAcquisitionError'
2726
const isTimeoutError = (e: unknown): e is typeof TimeoutError => e === TimeoutError
2827
const pkg = readPkg.sync()?.packageJson
2928

@@ -32,7 +31,7 @@ export interface Config {
3231
pubsub: Redis.Redis | Redis.Cluster
3332
pubsubChannel: string
3433
lock: Partial<redislock.Config>
35-
log: P.Logger | boolean
34+
log: pino.Logger | boolean
3635
lockPrefix: string
3736
debug: boolean
3837
name: string
@@ -66,7 +65,7 @@ function hasProp<K extends PropertyKey>(data: object, prop: K): data is Record<K
6665
* @param lockPrefix - used for creating locks in redis
6766
*/
6867
export class DistributedCallbackQueue {
69-
public readonly logger: P.Logger
68+
public readonly logger: pino.Logger
7069
private readonly lockPrefix: string
7170
private readonly client: Config['client']
7271
private readonly pubsub: Config['pubsub']
@@ -108,7 +107,7 @@ export class DistributedCallbackQueue {
108107
this.logger.info('Initialized...')
109108
}
110109

111-
static isCompatibleLogger(logger: unknown): logger is P.Logger {
110+
static isCompatibleLogger(logger: unknown): logger is pino.Logger {
112111
if (typeof logger !== 'object' || logger == null) {
113112
return false
114113
}
@@ -122,7 +121,7 @@ export class DistributedCallbackQueue {
122121
return true
123122
}
124123

125-
static initLogger(options: Partial<Pick<Config, 'log' | 'debug' | 'name'>>): P.Logger {
124+
static initLogger(options: Partial<Pick<Config, 'log' | 'debug' | 'name'>>): pino.Logger {
126125
const { log: logger, debug, name } = options
127126
const loggerEnabled = typeof logger === 'undefined' ? !!debug : logger
128127

@@ -198,7 +197,7 @@ export class DistributedCallbackQueue {
198197
try {
199198
await lock.acquire(lockRedisKey)
200199
return this.createWorker(lockRedisKey, lock)
201-
} catch (e) {
200+
} catch (e: unknown) {
202201
if (notLockAcquisitionError(e)) {
203202
// this is an abnormal error, need to post it and cancel requests
204203
// so that they dont hang

0 commit comments

Comments
 (0)