Skip to content

Commit 5f27223

Browse files
MichalStrehovskymichaelgsharp
authored andcommitted
Disable most of S.T.Json trimming tests on AOT the right way (dotnet#101418)
These don't seem to use the source generator, so they're not really "trimming tests" and obviously they don't work.
1 parent 035bcca commit 5f27223

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/TrimmingTests/System.Text.Json.TrimmingTests.proj

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
<Project DefaultTargets="Build">
22
<Import Project="$([MSBuild]::GetPathOfFileAbove(Directory.Build.props))" />
33

4-
<ItemGroup>
4+
<!-- These tests need to be rewritten to use source generator: https://github.com/dotnet/runtime/issues/53437,
5+
so conditioning on RunNativeAotTestApps -->
6+
<ItemGroup Condition="'$(RunNativeAotTestApps)' != 'true'">
57
<TestConsoleAppSourceFiles Include="Collections\Array.cs">
68
<AdditionalSourceFiles>Helper.cs</AdditionalSourceFiles>
79
</TestConsoleAppSourceFiles>

src/libraries/tests.proj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -653,7 +653,6 @@
653653
<ProjectExclusions Condition="'$(RunNativeAotTestApps)' == 'true'" Include="$(MSBuildThisFileDirectory)\System.Linq.Expressions\tests\TrimmingTests\System.Linq.Expressions.TrimmingTests.proj" />
654654
<ProjectExclusions Condition="'$(RunNativeAotTestApps)' == 'true'" Include="$(MSBuildThisFileDirectory)\System.Private.Xml\tests\TrimmingTests\System.Private.Xml.TrimmingTests.proj" />
655655
<ProjectExclusions Condition="'$(RunNativeAotTestApps)' == 'true'" Include="$(MSBuildThisFileDirectory)\System.Runtime\tests\System.Runtime.Tests\TrimmingTests\System.Runtime.TrimmingTests.proj" />
656-
<ProjectExclusions Condition="'$(RunNativeAotTestApps)' == 'true'" Include="$(MSBuildThisFileDirectory)\System.Text.Json\tests\System.Text.Json.Tests\TrimmingTests\System.Text.Json.TrimmingTests.proj" />
657656

658657
<TrimmingTestProjects Include="$(MSBuildThisFileDirectory)*\tests\**\*.TrimmingTests.proj"
659658
Exclude="@(ProjectExclusions)"

0 commit comments

Comments
 (0)