fix(review): track the previous hosted page whenever pages-publish returns a new id

A second wrong public landing returned a new id on the same host, so the first
public copy was overwritten in the sidecar and never deleted. Any id change now
moves the old copy under `stale` for deletion.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: kyle-sexton

docs/conventions/rendered-views/README.md

@@ -459,7 +459,7 @@ Producers on a type: `/visualization:present` (Slides).
   from a private repository when a caller skips the gate.
 - **The page id lives in the plugin's data directory**, in
   `hosted/<owner>__<repo>__<pr>.json` holding `pages-publish`'s JSON line, so a rebuild of the same
-  pull request's page replaces it. When the returned visibility differs from the sidecar's, the
+  pull request's page replaces it. When the returned id differs from the sidecar's, the
   lane writes the new sidecar with the old id listed under `stale`, then deletes it from the old
   host; an id whose delete fails stays under `stale` and is retried on the next publish.
 - **The save button stays on a top-level https page**, because the host's policy allows downloads.

plugins/review/skills/explain-change/scripts/publish-hosted.mjs

@@ -100,7 +100,7 @@ export function publishHosted({ page, repo, pr, repoVisibility, dataDir }) {
   // The old copy is recorded as stale before its delete runs, so a failed or interrupted delete is retried next time.
   const current = { id, visibility: landed, url };
   const stale = (old?.stale ?? []).filter((e) => e.id !== id);
-  if (old && old.visibility !== landed) stale.push(entry(old));
+  if (old && old.id !== id) stale.push(entry(old));
   writeSidecar(sidecar, current, stale);
 
   const result = { medium: "hosted", visibility: landed, url, reason: gate.reason };

plugins/review/tests/explain-change.test.mjs

@@ -556,6 +556,17 @@ process.exitCode = Number((process.argv[2] === "--delete" ? process.env.FAKE_DEL
     ]);
     assert.deepEqual(JSON.parse(readFileSync(at.sidecarPath, "utf8")), JSON.parse(answer(idB, "private")));
   });
+  test("a second wrong public landing under a new id still deletes the first", () => {
+    const idC = "C".repeat(22);
+    const at = setup(sample, answer(idA, "public"));
+    const out = publish(at, { visibility: "PRIVATE", out: answer(idC, "public") });
+    assert.equal(out.status, 1);
+    assert.deepEqual(calls(), [
+      [at.page, "--visibility", "private"],
+      ["--delete", idA, "--visibility", "public"],
+    ]);
+    assert.deepEqual(JSON.parse(readFileSync(at.sidecarPath, "utf8")), JSON.parse(answer(idC, "public")));
+  });
   test("a private page pages-publish puts on the public host exits 1 and names the URL; the sidecar keeps it for cleanup", () => {
     const at = setup();
     const out = publish(at, { visibility: "PRIVATE", out: answer(idB, "public") });