Repository navigation
Fix the action of a room key request cancellation. - #2247
Merged
Merged
Conversation
The spec states that the action of a room key request cancellation should be "cancel_request" but every known implementation uses "request_cancellation" instead. This patch fixes the spec to reflect the implementations.
Member
|
Is it possible to get a link to the implementations which do this? |
turt2live
self-requested a review
August 26, 2019 14:19
Member
|
also changelog please |
Contributor
Author
|
You want references in the commit message as well or just here? |
Member
|
Just here - it's to prove that we aren't making claims that "implementation do this" without evidence. |
Contributor
Author
|
Is this considered a spec clarification or a breaking change? |
Member
|
Clarification |
poljar
added a commit
to matrix-nio/matrix-nio
that referenced
this pull request
Aug 27, 2019
The spec stated that a key request cancellation should have the action "cancel_request" but riot and friends used "request_cancellation" instead. The spec will be changed to reflect the implementations so let us use the "request_cancellation" action as well. Upstream pull request: matrix-org/matrix-spec-proposals#2247
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec states that the action of a room key request cancellation
should be "cancel_request" but every known implementation uses
"request_cancellation" instead.
This patch fixes the spec to reflect the implementations.