more idiomatic string formatting

tsmathis · tsmathis · commit f822b4254eb2 · 2026-02-10T09:49:48.000-08:00
diff --git a/mp_api/client/core/client.py b/mp_api/client/core/client.py
@@ -591,9 +591,7 @@ def _query_resource(
                     )
 
                     predicate = (
-                        " WHERE batch_id NOT IN ("  # don't delete leading space
-                        + controlled_batch_str
-                        + ")"
+                        f"WHERE batch_id NOT IN ({controlled_batch_str})"
                         if not has_gnome_access
                         else ""
                     )
@@ -617,7 +615,7 @@ def _query_resource(
                         else None
                     )
 
-                    iterator = builder.execute("SELECT * FROM tbl" + predicate)
+                    iterator = builder.execute(f"SELECT * FROM tbl {predicate}")
 
                     file_options = ds.ParquetFileFormat().make_write_options(
                         compression="zstd"

Original file line number	Diff line number	Diff line change
`@@ -591,9 +591,7 @@ def _query_resource(`
`591`	`591`	`)`
`592`	`592`
`593`	`593`	`predicate = (`
`594`		`- " WHERE batch_id NOT IN (" # don't delete leading space`
`595`		`- + controlled_batch_str`
`596`		`- + ")"`
	`594`	`+ f"WHERE batch_id NOT IN ({controlled_batch_str})"`
`597`	`595`	`if not has_gnome_access`
`598`	`596`	`else ""`
`599`	`597`	`)`
`@@ -617,7 +615,7 @@ def _query_resource(`
`617`	`615`	`else None`
`618`	`616`	`)`
`619`	`617`
`620`		`- iterator = builder.execute("SELECT * FROM tbl" + predicate)`
	`618`	`+ iterator = builder.execute(f"SELECT * FROM tbl {predicate}")`
`621`	`619`
`622`	`620`	`file_options = ds.ParquetFileFormat().make_write_options(`
`623`	`621`	`compression="zstd"`