Commit 595ef3e
fix(RenderDebugOverlayPlugin): Require the
# Objective
- Fixes bevyengine#23673
- The `RenderDebugOverlayPlugin` is a `DefaultPlugin` that currently
only requires the `bevy_dev_tools` feature. However, under the hood in
its `init_render_debug_overlay_pipeline` system, it requires the
`MeshPipelineViewLayouts` resource to be initialized. The resource is
initialized in the `MeshRenderPlugin` (system
`init_mesh_pipeline_view_layouts`). The `MeshRenderPlugin` is part of
the `PbrPlugin`, which is a plugin in `DefaultPlugins` that requires the
`bevy_pbr` feature. This causes an error when you have a bevy project
with `DefaultPlugins`, without default features, and have the
`bevy_dev_tools` feature enabled.
## Solution
- The `RenderDebugOverlayPlugin` additionally requires the `bevy_pbr`
feature so that it can be included in `DefaultPlugins`. This ensures
`MeshPipelineViewLayouts` is initialized so that
`RenderDebugOverlayPlugin` can properly initialize.
- If `RenderDebugOverlayPlugin` can be more dexterously changed to still
be enabled with just the `bevy_dev_tools` feature, and `bevy_pbr`
specific logic can be handled within the plugin itself, then this can PR
can be rejected.
## Testing
- I created a scratch bevy project with the configuration described in
the linked issue, but pointing to this branch fix for its bevy
dependency. It successfully runs.bevy_pbr feature for inclusion in DefaultPlugins (bevyengine#23766)1 parent 18c53e2 commit 595ef3e
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
| 92 | + | |
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
| |||
0 commit comments