fixup! Set up CI to link against Sparkle 1 when in legacy builds

Use better `ln` command, and make sure non-publish builds don't have
Sparkle enabled so that it doesn't have to worry about using Sparkle 1
(since the OS is too old to use Sparkle 2), and to help test
--disable-sparkle builds in the matrix.

Author: ychin

.github/workflows/ci-macvim.yaml

@@ -79,7 +79,7 @@ jobs:
 
           # Use Sparkle 1 because Sparkle 2 requires newer OS version than our legacy build.
           # Later, we pass the --enable-sparkle_1 flag to configure to set the corresponding ifdef.
-          rm src/MacVim/Sparkle.framework && ln -s Sparkle_1.framework src/MacVim/Sparkle.framework
+          ln -fhs Sparkle_1.framework src/MacVim/Sparkle.framework
 
       # Set up, install, and cache gettext library for localization.
       #
@@ -158,6 +158,7 @@ jobs:
           else
             CONFOPT+=(
               --with-macarchs=x86_64
+              --disable-sparkle       # Don't include Sparkle for non-publish builds to avoid Sparkle 1 vs 2 issues, and to help test that this builds
             )
           fi
           if ${{ matrix.legacy == true }}; then