diff --git a/tools/testing/selftests/ublk/Makefile b/tools/testing/selftests/ublk/Makefile index 37883e9d50ec3..dc4aee6b60256 100644 --- a/tools/testing/selftests/ublk/Makefile +++ b/tools/testing/selftests/ublk/Makefile @@ -7,7 +7,9 @@ endif LDLIBS += -lpthread -lm -luring -TEST_PROGS := test_generic_02.sh +TEST_PROGS := test_cli_01.sh + +TEST_PROGS += test_generic_02.sh TEST_PROGS += test_generic_03.sh TEST_PROGS += test_generic_06.sh TEST_PROGS += test_generic_07.sh diff --git a/tools/testing/selftests/ublk/kublk.c b/tools/testing/selftests/ublk/kublk.c index 5b19bfcfa8d74..da542f2f325ca 100644 --- a/tools/testing/selftests/ublk/kublk.c +++ b/tools/testing/selftests/ublk/kublk.c @@ -2525,6 +2525,11 @@ int main(int argc, char *argv[]) while (i < argc && ctx.nr_files < MAX_BACK_FILES) { ctx.files[ctx.nr_files++] = argv[i++]; } + if (i < argc) { + fprintf(stderr, "too many backing files (maximum is %d)\n", + MAX_BACK_FILES); + return -EINVAL; + } ops = ublk_find_tgt(ctx.tgt_type); if (ops && ops->parse_cmd_line) { diff --git a/tools/testing/selftests/ublk/test_cli_01.sh b/tools/testing/selftests/ublk/test_cli_01.sh new file mode 100755 index 0000000000000..e937b8e20b8aa --- /dev/null +++ b/tools/testing/selftests/ublk/test_cli_01.sh @@ -0,0 +1,15 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0 + +UBLK_PROG="$(dirname "$0")/kublk" +expected="too many backing files (maximum is 4)" + +if output=$("${UBLK_PROG}" add -t stripe a b c d e 2>&1); then + echo "kublk accepted more than four backing files" + exit 1 +fi + +if [ "${output}" != "${expected}" ]; then + echo "unexpected error: ${output}" + exit 1 +fi