From 82ba8972f058a2941f580b44e249ceea5971d10a Mon Sep 17 00:00:00 2001 From: katelyn martin Date: Mon, 24 Feb 2025 00:00:00 +0000 Subject: [PATCH] chore(proxy/identity-client): remove `Default` bounds https://github.com/linkerd/linkerd2/issues/8733 for more information. see also, https://github.com/linkerd/linkerd2-proxy/pull/3651 for another related pull request. in hyper 1.x, `Incoming` bodies do not provide a `Default` implementation. compare the trait implementations here: * https://docs.rs/hyper/0.14.31/hyper/body/struct.Body.html#impl-Default-for-Body * https://docs.rs/hyper/latest/hyper/body/struct.Incoming.html#trait-implementations this commit removes these bounds from `linkerd_proxy_identity_client::Certify`. Signed-off-by: katelyn martin --- linkerd/proxy/identity-client/src/certify.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linkerd/proxy/identity-client/src/certify.rs b/linkerd/proxy/identity-client/src/certify.rs index ce2839b0df..61d313fe5e 100644 --- a/linkerd/proxy/identity-client/src/certify.rs +++ b/linkerd/proxy/identity-client/src/certify.rs @@ -93,7 +93,7 @@ impl Certify { C: Credentials, N: NewService<(), Service = S>, S: GrpcService, - S::ResponseBody: Default + Body + Send + 'static, + S::ResponseBody: Body + Send + 'static, ::Error: Into + Send, { debug!("Identity daemon running"); @@ -155,7 +155,7 @@ async fn certify( where C: Credentials, S: GrpcService, - S::ResponseBody: Default + Body + Send + 'static, + S::ResponseBody: Body + Send + 'static, ::Error: Into + Send, { let req = tonic::Request::new(api::CertifyRequest {