From 110bb438ff6351e3231d1421254fe2ef66f8c9cb Mon Sep 17 00:00:00 2001 From: JUN Date: Sun, 20 Sep 2026 02:25:12 +0900 Subject: [PATCH] docs: record contract campaign review and verification progress --- .../260919_contract_resolution/000_plan.md | 10 +++-- .../260919_contract_resolution/001_status.md | 10 +++-- .../035_static_policy_resolver.md | 44 +++++++++++++++++++ .../037_acceptance_ledger.md | 8 ++-- .../038_metrics_review.md | 38 ++++++++++++++++ .../040_preview_review.md | 12 +++++ 6 files changed, 111 insertions(+), 11 deletions(-) diff --git a/devlog/_plan/260919_contract_resolution/000_plan.md b/devlog/_plan/260919_contract_resolution/000_plan.md index f0d238bf18f..6dd3846a1eb 100644 --- a/devlog/_plan/260919_contract_resolution/000_plan.md +++ b/devlog/_plan/260919_contract_resolution/000_plan.md @@ -16,13 +16,13 @@ Evidence lives in this unit; previous implementation specifications remain in `d ## Ownership and dependencies -| Lane | Sole issue ownership | File domains and sequence | +| Lane | Issue and layer ownership | File domains and sequence | | --- | --- | --- | -| Runtime | #5109 #5110 #5111 #5113 #5115 #5118 #5122 #5123 #5124 | Raw transport contract, custom input consistency, send accounting, journal ownership and continuation policy. Stack null-body/coding only if a real shared helper dependency exists; upload can stay independent. Keep stream and state changes separate. | -| Policy and operator | #5112 #5114 #5116 #5117 #5119 #5120 #5121 | Schema reports before reject-lossy policy, static merge parity before consolidation, identity hints separate from availability, authority-map/tooling, optional metrics and pure preview, documentation alignment. Stack by these dependencies; independent docs can land separately. | +| Runtime | #5109 #5110 #5111 #5113 #5115 #5118 (server) #5122 #5123 #5124 | Raw transport contract, custom input consistency, send accounting, journal ownership and continuation policy. Stack null-body/coding only if a real shared helper dependency exists; upload can stay independent. Keep stream and state changes separate. | +| Policy and operator | #5112 #5114 #5116 #5117 #5118 (dashboard) #5119 #5120 #5121 | Schema reports before reject-lossy policy, static merge parity before consolidation, identity hints separate from availability, authority-map/tooling, optional metrics and pure preview, documentation alignment. Stack by these dependencies; independent docs can land separately. | | Coordinator | Review, CI, base/merge judgment and issue closure | Workers never merge or close issues. Cross-lane shared test-layout/structure changes are serialized at integration, with no cap increases or dropped regressions. | -The user chose two different main-task models and a specific subagent model. Runtime/model selection provenance stays in task records rather than public repository artifacts. Workers may use unlimited useful subagent rounds; concurrent workers have disjoint writes and never perform branch-level git operations in parallel on one checkout. +Workers may use unlimited useful subagent rounds; concurrent workers have disjoint writes and never perform branch-level git operations in parallel on one checkout. ## Integration policy @@ -51,3 +51,5 @@ Ownership amendment: #5115 moved to the runtime owner after the policy owner con Independent preparation audit accepted the #5115 ownership amendment: `knownModelIdsForProvider` is byte-identical across #5174, the registry entry type is unchanged by that layer, and the new helper has no static-policy dependency. Expected later overlap is import ordering and line movement; integration must retain both independent changes and obtain new-head hosted proof. Second ownership amendment: #5118 transferred to the existing runtime owner after confirmation that no implementation writer, branch or commit existed. Server and dashboard delivery remain required, with the prior private pre-build audit incorporated before implementation. Metrics-to-preview shared-route integration is serialized; preparation can proceed in disjoint files. Dashboard evidence must satisfy the actual file-based screenshot gate using hosted artifacts under the no-local-build restriction. No third implementation owner was created. + +Ownership refinement for #5118: the runtime owner retains server/writer/routes/backend tests and documentation; the existing policy owner takes the dashboard and its tests after explicit release of the untouched layer. Delivery remains server parent #5185 followed by a manually chained dashboard child, with independent reviews, each required hosted gate and actual screenshot evidence. No acceptance criterion or execution restriction changes. diff --git a/devlog/_plan/260919_contract_resolution/001_status.md b/devlog/_plan/260919_contract_resolution/001_status.md index 0b92cf7613c..231b881e002 100644 --- a/devlog/_plan/260919_contract_resolution/001_status.md +++ b/devlog/_plan/260919_contract_resolution/001_status.md @@ -1,15 +1,15 @@ # Campaign status -Status: ACTIVE. Thirteen of the sixteen original issues are resolved and closed. Remaining: #5114, #5117, #5118. Supplementary sideband recovery #5161 and send-assertion follow-up #5170 are merged. Runtime ownership #5157 is merged. Strict-policy child #5167 is merged. Static-policy resolver/consumer stack #5171/#5174 and metrics #5183 remain under review and hosted verification; preview #5185 is a draft. Integration snapshot at 2026-09-19T15:27:51Z: #5167 at `96a6de86b71cf8a8f78959e0bf626dac642510a7`. +Status: ACTIVE. Thirteen of the sixteen original issues are resolved and closed. Remaining: #5114, #5117, #5118. Resolver parent #5171 landed at `efb55e71e547ac83563e1d45dd60fb0b646e6cf7`; consumer #5174 remains open after a macOS job timeout, with a diagnostic rerun active at the same head. Metrics #5183 has further regression coverage pending after its latest correction. Preview #5185 remains a draft; server and dashboard work continue in separate existing owner checkouts. No additional issue closure is claimed. ## Owners | Lane | State | Issues | | --- | --- | --- | -| Runtime | Active in an isolated worktree | #5109 #5110 #5111 #5113 #5115 #5118 #5122 #5123 #5124 | -| Policy and operator | Active in an isolated worktree | #5112 #5114 #5116 #5117 #5119 #5120 #5121 | +| Runtime | Active in an isolated worktree | Remaining: #5118 server, writer, routes, backend tests and documentation | +| Policy and operator | Active in an isolated worktree | Remaining: #5114, #5117 and #5118 dashboard with its tests | -Private orchestration records retain the actual task handles, model-selection evidence and wake cursors. The current coordinator heartbeat is ACTIVE at a 20-minute interval. It follows the two existing implementation owners; it must not duplicate them. The coordinator owns integration and issue closure. +Private orchestration records retain the actual task handles and wake cursors. The current coordinator heartbeat is ACTIVE at a 20-minute interval. It follows the two existing implementation owners; it must not duplicate them. The coordinator owns integration and issue closure. ## Current evidence @@ -134,3 +134,5 @@ Second ownership amendment: #5118 transferred to the existing runtime owner afte #5177 is integrated and #5115 closed after complete acceptance verification. Current progress is12/16; remaining issues are #5112/#5114/#5117/#5118. The independent decode-hint change landed before policy migration after a recorded source-based sequencing amendment. The current-task heartbeat was updated and read back ACTIVE with the existing twenty-minute cadence. It now reflects twelve closed issues, runtime ownership of #5118, policy ownership of #5112/#5114/#5117, and the remaining publication/visual verification duties. Other task monitors were not modified. + +Current verified ledger remains thirteen closed issues and three open (#5114/#5117/#5118). The policy owner now owns only the dashboard child layer of #5118 in addition to #5114/#5117; the runtime owner retains its server, writer, routes, backend tests and documentation. The runtime handoff confirmed no dashboard writer, branch or commit existed. The two-owner limit, manual parent-child delivery and actual screenshot requirement remain unchanged. diff --git a/devlog/_plan/260919_contract_resolution/035_static_policy_resolver.md b/devlog/_plan/260919_contract_resolution/035_static_policy_resolver.md index 6d6a5c04872..40cfefa2cc0 100644 --- a/devlog/_plan/260919_contract_resolution/035_static_policy_resolver.md +++ b/devlog/_plan/260919_contract_resolution/035_static_policy_resolver.md @@ -45,3 +45,47 @@ Parent6892 narrow review found one cross-source provenance mismatch: a registry Parent `844cea4e0f11b5fa78fb5b1352a6949f4ab19035` adds merged winning-key provenance; the consumer stack is published on it at `304648706a360a737cad4d6473b9d164869e4c45`. Narrow parent re-review and exact-head hosted checks are pending. Running checks are not recorded as passing execution evidence. Independent review accepted winning-key provenance at `844cea4e0f11b5fa78fb5b1352a6949f4ab19035`, including cross-source exact/family precedence and explicit false. Source and provenance now share the same key-selection order. Current parent/child hosted proof remains in progress. + +Refreshed consumer head3046487 reached later existing cases and exposed two further contract regressions: inbound protocol is lost during Responses replay for Chat/Anthropic, and an explicit provider-level service-tier false is not retained by the catalog. Completed hosted job logs were sent to the owner and an independent boundary review; existing expectations remain authoritative. Earlier fixes are not proof of complete migration. + +Independent review localized the remaining consumer regressions to final-route inbound recapture, preserving captured configured intent for Fast eligibility, and explicit-empty default-map semantics during gather enrichment. Owner received exact source boundaries and must retain the original assertions. Captured dynamic eligibility remains distinct from shared static merge authority; a generic static value must not override an explicit disabled result. + +Remaining parent public review points to a documentation precision fix: the observed-limit projection may fill an absent static cap; it remains unknown only when both inputs are absent. Main confirmed source behavior and requested a call-local wording correction that preserves the immutable static policy. No runtime change is needed for that comment. + +Parent844 hosted run35451826594 ended with one macOS timing assertion: an unchanged stalled-stdout case took256ms against its250ms bound; 13,652 cases passed and22 skipped in that shard. Its test and adapter files are byte-unchanged against current dev. This is a timing-jitter candidate, not a proven resolver defect or a pass. Owner was told not to widen/skip the assertion and to use the next already-required documentation head for fresh CI rather than repeatedly rerun the superseded head. + +Consumer correction124e34f778 is under narrow review for all initial/fallback route recaptures, captured Fast eligibility and explicit-empty default-map semantics. Parent documentation correction7896b715 was inspected and preserves source behavior while clarifying call-local observed-limit filling. New-head hosted evidence remains required. + +Independent review passed `124e34f778913f8adcc1ff1fde66f7d5379d9e7a`: all route-selection paths recapture inbound protocol before adapter consumption; captured Fast intent is authoritative for publication; an explicit empty reasoning-default map retains its established fallback. All three original regression files are unchanged. Current-head hosted proof is still required. + +Child67bc1488 is a descendant of corrected parent7896b715; its source/tests match the independently reviewed consumer fix. A small catalog-document merge artifact retains parent-only migration wording and a duplicate fragment. Owner was asked to make that paragraph describe the final migrated contract without changing implementation. New-head CI and final public review remain required. + +Child documentation cleanupf5df7cb049 removes only the obsolete parent-only migration sentence and duplicate fragment. Main verified the final catalog contract remains consistent with the migrated implementation and frozen gather behavior. Current-head hosted verification remains required. + +Resolver parent #5171 merged as `efb55e71e547ac83563e1d45dd60fb0b646e6cf7` at2026-09-19T16:10:55Z. Head7896b715 passed every applicable hosted check and aggregate [35453258484](https://github.com/lidge-jun/opencodex/actions/runs/35453258484); macOS logs show36 parity cases executing. Independent reviews and public threads are complete. Current merge preserves reviewed core/test blobs and current integration documentation/layout. Actual dev ancestry verified. #5114 remains OPEN until child#5174 is restacked, verified and integrated; parent branch retained. + +Post-parent cascade `20ac21d4a650399870c397de8c8fad608f43488c` passed independent union review: reviewed consumer changes and decoded-identity helper remain, and current schema/ownership/policy documentation and layout inventories coexist. No cap change or semantic cascade regression was found. Current-head hosted checks remain running. + +Current post-parent child20ac reached an unchanged source-oracle assertion expecting the former terminal-repair helper call. The implementation intentionally consumes captured static policy instead. Owner received the exact assertion anchor to update while retaining all platform/relay invariant checks; no runtime fallback or removed assertion was requested. + +Independent oracle-fix review passed head6878d8b24: the source assertion now names captured terminal policy while preserving every platform, bounded relay, native WebSocket and failure invariant. Hosted CI at that head remains required. + +Child6878d8b24 reached green applicable hosted CI. Final public review requested two bounded end-to-end precedence cases: API-key provider lower/higher configured limits through capture into catalog, and a family-specific context limit competing with a provider-wide default. These correspond to the issue's explicit consumer-parity acceptance. Owner was asked for focused coverage only; an independent lookup checks for existing equivalent tests before duplication. No current source defect was asserted by these comments. Merge remains held until disposition and fresh head evidence. + +Independent existing-test lookup confirmed the two requested coverage cases are not duplicates: lower/higher limits are tested separately in routing and augmentation, but not through capture-to-catalog; existing family-context tests omit the competing provider-wide fallback. Owner was asked for only the minimal three cases, retaining existing tests and file-size constraints. + +Coverage commit `3b731ac5d95eec4b4f430abf80c571924a1d09c3` adds the minimal capture-to-catalog lower/higher limit and family-versus-provider context cases. Independent test review checks activation and fixed expected values; production source is unchanged in this delta. Fresh exact-head hosted verification is required. + +Review of3b731ac5 found the API capture test incomplete: it covers only configured-lower context/output values, while the requested positive-cap contract applies to context and max input and also requires an above-registry case. Owner received the exact two-row correction; the Anthropic family-versus-provider/observed test passed review. No production change is requested. + +Corrected coverage head `bc9e61aed886252a4bbb33cef340ae8dc91ac557` is published with the requested lower/higher context and max-input cases. Independent review is scoped to that test correction; the previously accepted family-context case is retained. New-head hosted proof remains required. + +Independent test re-review passed bc9e61aed8: configured lower and higher context/max-input values are checked against fixed expected caps in both captured maps and emitted catalog rows; the family-precedence conflict remains covered. Current-head hosted verification and final public-thread disposition remain the only known gates for this test delta. + +Final source integration review passed at bc9e61aed886252a4bbb33cef340ae8dc91ac557 against dev efb55e71e547ac83563e1d45dd60fb0b646e6cf7. The conflict-free merge tree139eebbab0cefb4a9113a16a26e6cd4bc6eeb34e equals the reviewed head tree. Production consumers are unchanged from6878d8b24a; later edits add only the accepted precedence cases. Parent policy, schema and ownership contracts and registry identity hints remain present. No public review thread is unresolved. Hosted run35456151926 still has macOS shard1 running; no merge or issue closure is claimed. + +Hosted execution evidence for the four consumer regressions was read directly from run35456151926 Linux shard4 job105931863842: frozen capture with late credential replacement, virtual wire identity replacement, lower/higher API context/input caps, and family context precedence all passed. The macOS shard1 handle105931863680 was independently confirmed in progress in its Test step. No completed-job failure was observed and no rerun or cancellation was started. + +Run35456151926 attempt1 ended with macOS shard1 cancellation and aggregate failure. GitHub annotation confirms the20-minute job limit; the last file group was tests/clients/client-connect.test.ts, with no subsequent result. Head bc9e61 is unchanged. One targeted diagnostic rerun of job105931863680 was accepted as attempt2 and read back queued. This measures recurrence; it is not a fix or environmental attribution. Source investigation is active, with no timeout increase, skipped case or local execution. Merge remains held. + +Source diagnosis narrowed the missing observation to file startup, not a proven environmental cause: top-level imports, synchronous warm-up scanning and child startup remain distinct hypotheses. Earlier green-head blob identity is not causal proof. If the diagnostic run repeats without phase evidence, add bounded phase markers before changing harness behavior. Attempt2 job105935450017 was read back in progress on the same head. diff --git a/devlog/_plan/260919_contract_resolution/037_acceptance_ledger.md b/devlog/_plan/260919_contract_resolution/037_acceptance_ledger.md index 733804705fe..f9a8cd6cabb 100644 --- a/devlog/_plan/260919_contract_resolution/037_acceptance_ledger.md +++ b/devlog/_plan/260919_contract_resolution/037_acceptance_ledger.md @@ -9,11 +9,11 @@ This checkpoint does not declare the campaign complete. Current disposition: thi | #5111 | Closed; landed through #5126 | [`af4f744c75`](022_pr_5126.md); closure at 2026-09-19T10:01:05Z. | | #5112 | Closed; parent #5162 and child #5167 landed | [`96a6de86b7`](034_strict_schema_policy.md); current closure verified after both ancestries. | | #5113 | Closed; landed through #5129 | [`bb2fa5ab25`](024_pr_5129.md); closure at 2026-09-19T10:04:15Z. | -| #5114 | Open; incomplete | Resolver #5171 passed hosted CI but has unresolved review findings; consumer #5174 has hosted failures under repair. Both layers must land. [Record](035_static_policy_resolver.md). | +| #5114 | Open; incomplete | Resolver #5171 landed at efb55e71e5; consumer #5174 has an unresolved macOS startup timeout under diagnosis. Its current-head verification and landing remain required. [Record](035_static_policy_resolver.md). | | #5115 | Closed; landed through #5177 | [`838af40f1b`](039_decode_hint_review.md); closure at 2026-09-19T15:01:16Z. | | #5116 | Closed; landed through #5155 | [`6d42723387`](030_pr_5155.md); closure at 2026-09-19T11:07:05Z. | -| #5117 | Open; incomplete | Opt-in metadata-only exporter is being implemented; full privacy/auth/counting/lifecycle acceptance remains unverified. [Record](000_plan.md). | -| #5118 | Open; incomplete | Server-owned read-only preview, fingerprint validation and dialog integration still required. [Record](000_plan.md). | +| #5117 | Open; incomplete | Metrics #5183 is implemented with reviewed terminal-path corrections; acquisition regression coverage and current-head hosted verification remain required. [Record](038_metrics_review.md). | +| #5118 | Open; incomplete | Draft server #5185 and its dashboard child remain incomplete; source acceptance, hosted execution and actual visual evidence are required. [Record](040_preview_review.md). | | #5119 | Closed; landed through #5153 | [`f117c20d12`](029_pr_5153.md); closure at 2026-09-19T10:21:08Z. | | #5120 | Closed; landed through #5134 | [`1b54f2940b`](026_pr_5134.md); closure at 2026-09-19T09:02:10Z. | | #5121 | Closed; landed through #5138 | [`5ce51cb554`](027_pr_5138.md); closure at 2026-09-19T10:08:29Z. | @@ -28,3 +28,5 @@ Publication review checkpoint: independent re-review accepted the corrected Engl Public checkpoint #5175 landed as `57b1df792ef7e66e17b0110727eefdd5387e164d` at 2026-09-19T14:13:30Z after reviewed head `128a47ea9db9b93ffc80fc2d42a2f4cddcc8f8c0` passed all applicable hosted checks and public review. Runtime checks were change-inapplicable, not executed. The original coordinator checkout staging was retained. Future implementation outcomes still require ledger updates and independent completion proof. At the #5123 checkpoint, the total was eleven closed and five open; this earlier checkpoint remains historical evidence. + +Second public checkpoint #5187 landed as `00ac9b6a6c0707b8e315b88f334c396162909b17` at2026-09-19T15:45:45Z after applicable hosted CI and all publication findings were resolved. It records thirteen completed issues and three open issues; later working updates remain pending publication. diff --git a/devlog/_plan/260919_contract_resolution/038_metrics_review.md b/devlog/_plan/260919_contract_resolution/038_metrics_review.md index 358b76358f6..bcd41bd0c35 100644 --- a/devlog/_plan/260919_contract_resolution/038_metrics_review.md +++ b/devlog/_plan/260919_contract_resolution/038_metrics_review.md @@ -33,3 +33,41 @@ Review of the new exception finalizer found a concrete pre-response cancellation Hosted run35451702720 atbf462 again falsified assumptions in the error/cancellation fixtures: the client fetch resolved rather than rejecting in the observed handler-error case, and the expected upstream cancel callback was not observed before the bounded deadline. Owner and reviewer were told to derive a deterministic real-server harness boundary from source and existing conventions, preserve the actual metrics assertions, and avoid changing assertions speculatively or raising timeouts. Head `8b589b3114b82027e164f38e08dc580803c89c43` adds cancellation-aware status/reason to the pre-response finalizer and a real pending-body abort case. That correction is under narrow review. The earlier read-error and cancellation fixture execution failures are separate and remain unresolved until a deterministic harness and new hosted proof establish them. + +The8b589 production cancellation branch passed static review. Its new synthetic upstream body, however, did not observe the outgoing request abort signal; a mock is not automatically coupled to real network cancellation. Reviewer supplied an existing repository signal-aware fixture precedent. Owner was asked to attach rejection handling immediately, explicitly model upstream abort propagation, synchronize actual server finalization and retain the complete metrics assertions instead of assuming one Bun transport error shape. + +Fixture-harness redesign `052eedb5cd10f135f8760aed76a170168cffc624` is published. Independent review now checks that the expected error/cancellation boundaries are actually activated and synchronized rather than inferred from default client transport behavior. Exact metrics counts remain required, with fresh hosted CI. + +Combined harness review confirmed final-log observers run after the corresponding metrics update. Two deterministic-test corrections remain: explicitly handle the expected test server error without suppressing unexpected errors, and start rejecting deadlines only at await sites so early subscriptions cannot produce unhandled timeout rejections. The signal-aware abort/cancellation activations were accepted. + +Primary-source research (2026-09-20) opened the [Bun HTTP error-handling contract](https://bun.com/docs/runtime/http/error-handling) in the requested browser and read the [server reload reference](https://bun.com/reference/bun/Server/reload). A handler error without an explicit error response uses Bun's default response path; a dedicated error handler can supply a deterministic response. The reload reference alone does not prove an error-only option object is accepted by the project's pinned types. Owner was given these boundaries to implement a test harness without assuming a universal client rejection or altering production error semantics. No local server or test was run. + +Hosted1c1c8229 confirms the pre-response client-abort regression now passes. The two already-tracked read-error/default-handler and streaming cancellation observation cases still fail; no new defect class is inferred. Owner has the completed-job evidence and the confirmed official error-handler contract. + +Fixture correction d4ee3baf3b installs a narrowly scoped explicit test server error handler, asserts the exact expected error and absence of unexpected errors, and makes event subscriptions non-rejecting until bounded observation. Independent review is checking the full cancellation activation rather than assuming client abort automatically controls a synthetic upstream body. Production behavior is unchanged in this test delta. + +The revised error-handler and observer harness passed review. The remaining SSE fixture still ignored the outgoing abort signal: production permits a bounded post-cancel drain, so an indefinitely open mock cannot establish prompt finalization. Reviewer corrected the earlier acceptance and traced the real signal path. Owner was asked to make the second SSE mock honor that signal, preserving both the production drain bound and the test deadline. No timeout increase was requested. + +Final targeted SSE fixture correction `794948670241886841b6ce6e89524bf2a63c5c1b` explicitly connects the second synthetic response to the outgoing request abort signal. No deadline or metrics assertion changed. Narrow independent review and fresh hosted checks are pending. + +Independent final narrow review passed the SSE abort linkage at79494867: it uses the actual outgoing signal, handles pre-aborted input, errors the pending mock once, and preserves deadlines and all counts. Earlier error-handler and non-rejecting observer corrections remain accepted. Only actual current-head hosted execution can establish runtime success. + +Head79494867 completed applicable hosted CI, but final public review exposed a remaining classification case: successful WebSocket upgrades finalize with101 and were counted failed by the fallback200–399 rule. Main verified source and requested explicit101 success while retaining cancellation and terminal-error precedence, with an upgrade regression. Green CI does not override this concrete gap. + +Head `28ab81c3e44b8bac548766702d3385efd8dbde8d` adds101 success classification after existing terminal/cancellation precedence, a real live-sideband upgrade scrape regression and explicit failed/incomplete101 precedence cases. Narrow independent review and fresh hosted verification are pending. + +Independent review passed the final101 classification correction at `28ab81c3e44b8bac548766702d3385efd8dbde8d`. The real upgrade path and metric are exercised; cancellation and failed/incomplete terminal precedence remain unchanged. No known static blocker remains at this head, but applicable hosted checks are still running. + +The101 correction at28ab81c3 passed independent review with real upgrade activation and retained terminal/cancellation precedence. Current-head hosted verification remains pending; the earlier79494867 green run is not substituted for this head. + +Hosted28ab81c3 cleared the earlier read-error and cancellation cases, but the new live101 fixture failed before the WebSocket opened. Owner and reviewer are checking the route's actual admission/configuration prerequisites against an existing successful upgrade harness. The metrics classifier is not proven through that fixture until the real upgrade is activated; helper-only substitution or relaxed admission was not requested. + +The live101 fixture rejection was traced to an ineligible synthetic provider: route admission refused before the injected local WebSocket factory ran. Owner received an existing canonical-key fixture precedent and a test-only setup correction, while retaining real upgrade/count assertions and unchanged production eligibility. The earlier static activation claim was corrected. + +Independent review passed the canonical101 fixture correction at `009317c24d46f3e03156bac3fc5b4b468ddaebec`. It meets the actual realtime selector prerequisites while redirecting only the injected upstream dial to a real local test server, asserts one factory invocation, and retains status/count/precedence/cleanup checks. Current-head hosted CI remains required. + +Exact-head hosted run35456050014 passed at009317c24d46f3e03156bac3fc5b4b468ddaebec. Final public and independent review nevertheless confirmed two uncovered corrections: the live-upgrade fixture creates its upstream before the cleanup scope, and six post-context live-sideband terminal exits omit request finalization (admission refusal, resolver exception, acquisition cancellation/timeout, pre-upgrade cancellation, upgrade exception and rejected upgrade). The owner is correcting those paths with preserved transport statuses and real-route regressions. Merge remains held; the green run is not full acceptance. + +Correction bf6a073cd23e15278d802b8f42f1eb5c54701ac2 is published with a request-local idempotent live-sideband finalizer, the six missing terminal exits and real-route cancellation/upgrade-failure regressions. The standalone upstream now has an outer cleanup scope. Independent re-review is in progress and exact-head hosted run35457502555 is active; no new passing execution claim yet. + +Independent bf6a073cd2 review accepted production status/metadata and once-only finalization across all six exits, plus the repaired fixture cleanup. The acquisition-cancellation/timeout branch still lacks actual-route regression activation. The owner received that focused coverage requirement and an existing deterministic timer fixture precedent. The already-added pre-upgrade cancellation and upgrade throw/refusal cases remain retained. diff --git a/devlog/_plan/260919_contract_resolution/040_preview_review.md b/devlog/_plan/260919_contract_resolution/040_preview_review.md index c65794e4e09..8f4ec0274e6 100644 --- a/devlog/_plan/260919_contract_resolution/040_preview_review.md +++ b/devlog/_plan/260919_contract_resolution/040_preview_review.md @@ -5,3 +5,15 @@ Issue #5118 remains open. [PR #5185](https://github.com/lidge-jun/opencodex/pull The owner is continuing implementation under independent review. Detailed working review records are retained in ignored scratch. Draft publication and an individual review result are not completion evidence. No local tests, typecheck, build, installation or proxy runtime execution were performed. Applicable exact-head hosted CI and actual dashboard visual evidence remain required; a built preview artifact alone is not a screenshot. + +Draft #5185 now includes a read-only preview entrypoint and a filesystem regression at d987ee4fc9. Independent source/test review and hosted verification are in progress. Management routes, confirmed mutation binding, profile/restore coverage and the dashboard remain unfinished; the draft is not merge-ready. + +The untouched dashboard layer was released to the existing policy owner. The runtime owner retains the server implementation and its documentation. The dashboard will be a manual child of #5185 and must provide actual visual evidence. Server implementation and independent review continue; #5118 remains open. + +The server now includes the profile preview route, a bound restore success case and structure documentation at50ecfda2c2. Scoped review accepted route reachability and the complete store-content witness, but identified further corrections and missing profile coverage. The owner received the private findings; the server and dashboard remain incomplete. + +The additional roster invalidation change at e53d68d0a4 is not yet accepted: review found its new regression does not activate an actual successful discovery publication. The owner is correcting that mismatch; a separate source lookup is checking the existing configuration revision owner. Accepted route and immutability results remain recorded separately from these open requirements. + +Correction1c37027d9d now asserts bound restore succeeds, deletes the initially absent target and retains both the prior apply and new restore journal entries. Main inspected the exact diff and its absent-file setup. This corrects the previously invalid postcondition; actual hosted execution, profile history selection and roster authority verification remain outstanding. + +Server corrections e99250dfe8 and c4d207cabf now address cache-content publication revision and selected restore operation identity. Independent re-review is checking those exact changes, including actual publication/removal paths and history-store consistency. Configuration authority and complete profile regression evidence remain required.