fix super update error

Author: ozer550

contentcuration/contentcuration/tests/viewsets/test_contentnode.py

@@ -797,7 +797,6 @@ def test_update_completion_criteria_model_to_determined_by_resource_edge_case(se
                     )
                 ],
         )
-
         self.assertEqual(len(response.data["errors"]), 0)
         updated_contentnode = models.ContentNode.objects.get(id=contentnode.id)
         self.assertEqual(updated_contentnode.extra_fields["options"]["completion_criteria"]["model"], completion_criteria.DETERMINED_BY_RESOURCE)

contentcuration/contentcuration/utils/nodes.py

@@ -455,11 +455,9 @@ def migrate_extra_fields(extra_fields):
     return extra_fields
 
 
-def validate_and_conform_to_schema_threshold_none(validated_options):
-    completion_criteria_validated = validated_options.get("completion_criteria", {})
+def validate_and_conform_to_schema_threshold_none(completion_criteria_validated):
     model = completion_criteria_validated.get("model", {})
     if model in ["reference", "determined_by_resource"]:
         if "threshold" not in completion_criteria_validated or completion_criteria_validated["threshold"] is not None:
             completion_criteria_validated["threshold"] = None
-    validated_options["completion_criteria"] = completion_criteria_validated
-    return validated_options
+    return completion_criteria_validated

contentcuration/contentcuration/viewsets/contentnode.py

@@ -279,15 +279,15 @@ class CompletionCriteriaSerializer(JSONFieldDictSerializer):
     model = CharField()
     learner_managed = BooleanField(required=False, allow_null=True)
 
+    def update(self, instance, validated_data):
+        validated_data = validate_and_conform_to_schema_threshold_none(validated_data)
+        return super(CompletionCriteriaSerializer, self).update(instance, validated_data)
+
 
 class ExtraFieldsOptionsSerializer(JSONFieldDictSerializer):
     modality = ChoiceField(choices=(("QUIZ", "Quiz"),), allow_null=True, required=False)
     completion_criteria = CompletionCriteriaSerializer(required=False)
 
-    def update(self, instance, validated_data):
-        validated_data = validate_and_conform_to_schema_threshold_none(validated_data)
-        return super(ExtraFieldsOptionsSerializer, self).update(instance, validated_data)
-
 
 class ExtraFieldsSerializer(JSONFieldDictSerializer):
     randomize = BooleanField()