Merge pull request #3240 from learningequality/deepsource-fix-72ad7193

Refactor unnecessary `else` / `elif` when `if` block has a `continue` statement

Author: rtibbles

contentcuration/contentcuration/models.py

@@ -606,8 +606,7 @@ def generate_new_token(cls):
             token = proquint.generate()
             if SecretToken.exists(token):
                 continue
-            else:
-                break
+            break
         # after TRIALS attempts and we didn't get a unique token,
         # just raise an error.
         # See https://stackoverflow.com/a/9980160 on what for-else loop does.

deploy/probers/postmark_api_probe.py

@@ -27,13 +27,12 @@ def do_probe(self):
 
             if passing:
                 continue
-            else:
-                raise Exception("Postmark's `%s` service has status %s, but we require one of the following: %s" % (
-                        service['name'],
-                        service['status'],
-                        allowed_statuses
-                    )
+            raise Exception("Postmark's `%s` service has status %s, but we require one of the following: %s" % (
+                    service['name'],
+                    service['status'],
+                    allowed_statuses
                 )
+            )
 
 
 if __name__ == "__main__":