Skip to content

Commit 6a10c68

Browse files
authored
Merge pull request #3854 from LianaHarris360/missing-bullet-points
Added bullet points between languages on sign-in page
2 parents 2289f6c + 40b0019 commit 6a10c68

1 file changed

Lines changed: 4 additions & 30 deletions

File tree

contentcuration/contentcuration/frontend/shared/languageSwitcher/LanguageSwitcherList.vue

Lines changed: 4 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<template>
22

33
<div>
4-
<KButtonGroup style="margin-top: 8px;">
4+
<KButtonGroup style="margin-top: 8px;" class="dots">
55
<KIconButton
66
icon="language"
77
aria-hidden="true"
@@ -10,7 +10,7 @@
1010
@click="showLanguageModal = true"
1111
/>
1212
<span
13-
class="dotsSpan selected"
13+
class="selected"
1414
:style="{ 'margin': '0' }"
1515
:title="selectedLanguage.english_name"
1616
>
@@ -22,7 +22,6 @@
2222
:text="language.lang_name"
2323
:title="language.english_name"
2424
class="lang"
25-
:class="determineLangDirection(language.lang_direction)"
2625
appearance="basic-link"
2726
:style="{ 'margin': '0 2px' }"
2827
@click="switchLanguage(language.id)"
@@ -101,11 +100,6 @@
101100
.slice(0, this.numVisibleLanguages);
102101
},
103102
},
104-
methods: {
105-
determineLangDirection(direction) {
106-
return (!this.$isRTL && direction) || (this.$isRTL && !direction) ? 'dotsRtl' : 'dots';
107-
},
108-
},
109103
$trs: {
110104
showMoreLanguagesSelector: 'More languages',
111105
},
@@ -135,18 +129,8 @@
135129
text-align: left;
136130
}
137131
138-
.dots:not(:last-child)::after {
139-
// because it is a pseudo-element, text-decoration none only works with 'display: inline-block`
140-
display: inline-block;
141-
margin: 0 8px;
142-
font-size: 14pt;
143-
color: var(--v-grey-base);
144-
text-decoration: none;
145-
vertical-align: middle;
146-
content: '';
147-
}
148-
149-
.dotsSpan::after {
132+
// this selector applies to the elements defined in KButtonGroup
133+
.dots :not(:first-child, :last-child)::after {
150134
display: inline-block;
151135
margin: 0 6px;
152136
font-size: 14pt;
@@ -156,14 +140,4 @@
156140
content: '';
157141
}
158142
159-
.dotsRtl:not(:last-child)::before {
160-
display: inline-block;
161-
margin: 0 8px;
162-
font-size: 14pt;
163-
color: var(--v-grey-base);
164-
text-decoration: none;
165-
vertical-align: middle;
166-
content: '';
167-
}
168-
169143
</style>

0 commit comments

Comments
 (0)