From d95f6895a91e314442c17180d273ecec7f7ff76e Mon Sep 17 00:00:00 2001
From: Sven Weidenmann <sweidenmann@gmail.com>
Date: Thu, 21 May 2026 18:39:35 +0200
Subject: [PATCH] refactor: add missing @override decorator to
 PluginModelRuntime

Relates to #36406. Adds @override (17 decorators) to all ModelRuntime
protocol methods implemented in PluginModelRuntime: fetch_model_providers,
get_provider_icon, validate_provider_credentials, validate_model_credentials,
get_model_schema, invoke_llm, invoke_llm_with_structured_output,
get_llm_num_tokens, invoke_text_embedding, invoke_multimodal_embedding,
get_text_embedding_num_tokens, invoke_rerank, invoke_multimodal_rerank,
invoke_tts, get_tts_model_voices, invoke_speech_to_text, invoke_moderation.

@override is placed on the implementation methods only, not on the
@overload-decorated stubs of invoke_llm and invoke_llm_with_structured_output
(pyrefly's missing-override-decorator check targets the implementation).

Uses 'from typing import override' (Python 3.12+ stdlib) per the pattern
established in #36486.
---
 api/core/plugin/impl/model_runtime.py | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/api/core/plugin/impl/model_runtime.py b/api/core/plugin/impl/model_runtime.py
index 62573ba2f53e46..d555f4d9657f08 100644
--- a/api/core/plugin/impl/model_runtime.py
+++ b/api/core/plugin/impl/model_runtime.py
@@ -4,7 +4,7 @@
 import logging
 from collections.abc import Generator, Iterable, Sequence
 from threading import Lock
-from typing import IO, Any, Literal, cast, overload
+from typing import IO, Any, Literal, cast, overload, override
 
 from pydantic import ValidationError
 from redis import RedisError
@@ -118,6 +118,7 @@ def __init__(self, tenant_id: str, user_id: str | None, client: PluginModelClien
         self._provider_entities = None
         self._provider_entities_lock = Lock()
 
+    @override
     def fetch_model_providers(self) -> Sequence[ProviderEntity]:
         if self._provider_entities is not None:
             return self._provider_entities
@@ -130,6 +131,7 @@ def fetch_model_providers(self) -> Sequence[ProviderEntity]:
 
         return self._provider_entities
 
+    @override
     def get_provider_icon(self, *, provider: str, icon_type: str, lang: str) -> tuple[bytes, str]:
         provider_schema = self._get_provider_schema(provider)
 
@@ -172,6 +174,7 @@ def get_provider_icon(self, *, provider: str, icon_type: str, lang: str) -> tupl
         mime_type = image_mime_types.get(extension, "image/png")
         return PluginAssetManager().fetch_asset(tenant_id=self.tenant_id, id=file_name), mime_type
 
+    @override
     def validate_provider_credentials(self, *, provider: str, credentials: dict[str, Any]) -> None:
         plugin_id, provider_name = self._split_provider(provider)
         self.client.validate_provider_credentials(
@@ -182,6 +185,7 @@ def validate_provider_credentials(self, *, provider: str, credentials: dict[str,
             credentials=credentials,
         )
 
+    @override
     def validate_model_credentials(
         self,
         *,
@@ -201,6 +205,7 @@ def validate_model_credentials(
             credentials=credentials,
         )
 
+    @override
     def get_model_schema(
         self,
         *,
@@ -294,6 +299,7 @@ def invoke_llm(
         stream: Literal[True],
     ) -> Generator[LLMResultChunk, None, None]: ...
 
+    @override
     def invoke_llm(
         self,
         *,
@@ -357,6 +363,7 @@ def invoke_llm_with_structured_output(
         stream: Literal[True],
     ) -> Generator[LLMResultChunkWithStructuredOutput, None, None]: ...
 
+    @override
     def invoke_llm_with_structured_output(
         self,
         *,
@@ -396,6 +403,7 @@ def invoke_llm_with_structured_output(
             stream=stream,
         )
 
+    @override
     def get_llm_num_tokens(
         self,
         *,
@@ -422,6 +430,7 @@ def get_llm_num_tokens(
             tools=list(tools) if tools else None,
         )
 
+    @override
     def invoke_text_embedding(
         self,
         *,
@@ -443,6 +452,7 @@ def invoke_text_embedding(
             input_type=input_type,
         )
 
+    @override
     def invoke_multimodal_embedding(
         self,
         *,
@@ -464,6 +474,7 @@ def invoke_multimodal_embedding(
             input_type=input_type,
         )
 
+    @override
     def get_text_embedding_num_tokens(
         self,
         *,
@@ -483,6 +494,7 @@ def get_text_embedding_num_tokens(
             texts=texts,
         )
 
+    @override
     def invoke_rerank(
         self,
         *,
@@ -508,6 +520,7 @@ def invoke_rerank(
             top_n=top_n,
         )
 
+    @override
     def invoke_multimodal_rerank(
         self,
         *,
@@ -533,6 +546,7 @@ def invoke_multimodal_rerank(
             top_n=top_n,
         )
 
+    @override
     def invoke_tts(
         self,
         *,
@@ -554,6 +568,7 @@ def invoke_tts(
             voice=voice,
         )
 
+    @override
     def get_tts_model_voices(
         self,
         *,
@@ -573,6 +588,7 @@ def get_tts_model_voices(
             language=language,
         )
 
+    @override
     def invoke_speech_to_text(
         self,
         *,
@@ -592,6 +608,7 @@ def invoke_speech_to_text(
             file=file,
         )
 
+    @override
     def invoke_moderation(
         self,
         *,