Skip to content

Commit 7609bd9

Browse files
Kudokosmydel
authored andcommitted
Defines module for React-jsinspector (facebook#44252)
Summary: Defines module for `React-jsinspector` that for swift modules to integrate with. to fix expo/expo#28209, any podspec depends on HermesExecutorFactory should use ` add_dependency(s, "React-jsinspector", :framework_name => 'jsinspector_modern')` to add dependency. otherwise it will encounter the header not found issue because use_frameworks will change "jsinspector-modern" to "jsinspector_modern". to depend on React-jsinspector from expo-modules-core, we need it to define as a module. otherwise, it will have the error ``` The Swift pod `ExpoModulesCore` depends upon `React-jsinspector`, which does not define modules. To opt into those targets generating module maps (which is necessary to import them from Swift when building as static libraries), you may set `use_modular_headers!` globally in your Podfile, or specify `:modular_headers => true` for particular dependencies. ``` ## Changelog: [IOS] [CHANGED] - Add `DEFINES_MODULE` for React-jsinspector.podspec Pull Request resolved: facebook#44252 Test Plan: ci passed Reviewed By: cortinico Differential Revision: D56575102 Pulled By: cipolleschi fbshipit-source-id: 9b7b4568a3e499f0a741a79a846263118ff2d112
1 parent f3e7474 commit 7609bd9

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

packages/react-native/ReactCommon/jsinspector-modern/React-jsinspector.podspec

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ Pod::Spec.new do |s|
3838
s.compiler_flags = folly_compiler_flags
3939
s.pod_target_xcconfig = {
4040
"HEADER_SEARCH_PATHS" => "\"$(PODS_TARGET_SRCROOT)/..\" \"$(PODS_ROOT)/boost\" \"$(PODS_ROOT)/RCT-Folly\" \"$(PODS_ROOT)/DoubleConversion\" \"$(PODS_ROOT)/fmt/include\"",
41-
"CLANG_CXX_LANGUAGE_STANDARD" => "c++20"
41+
"CLANG_CXX_LANGUAGE_STANDARD" => "c++20",
42+
"DEFINES_MODULE" => "YES"
4243
}.merge!(use_frameworks ? {
4344
"PUBLIC_HEADERS_FOLDER_PATH" => "#{module_name}.framework/Headers/#{header_dir}"
4445
} : {})

0 commit comments

Comments
 (0)