review: update naming

Author: archandatta

server/cmd/api/api/api.go

@@ -336,7 +336,9 @@ func (s *ApiService) Shutdown(ctx context.Context) error {
 		s.cdpMonitor.Stop()
 	}
 	if s.captureSession != nil {
-		_ = s.captureSession.Close()
+		if err := s.captureSession.Close(); err != nil {
+			logger.FromContext(ctx).Error("failed to close capture session", "err", err)
+		}
 	}
 	return s.recordManager.StopAll(ctx)
 }

server/cmd/api/api/events.go

@@ -50,6 +50,11 @@ func (s *ApiService) PublishEvent(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
+	if ev.Type == "" {
+		http.Error(w, "type is required", http.StatusBadRequest)
+		return
+	}
+
 	// Derive category if caller omitted it — FileWriter returns error for empty category.
 	if ev.Category == "" {
 		ev.Category = events.CategoryFor(ev.Type)

server/cmd/api/api/events_publish_test.go

@@ -43,7 +43,7 @@ func TestPublishEvent(t *testing.T) {
 		svc, cs := newPublishTestService(t, logDir)
 
 		b, _ := json.Marshal(events.Event{
-			Type:     "liveview.click",
+			Type:     "liveview_click",
 			Category: events.CategoryLiveview,
 			Source:   events.Source{Kind: events.KindKernelAPI},
 			Data:     json.RawMessage(`{"x":100}`),
@@ -61,7 +61,7 @@ func TestPublishEvent(t *testing.T) {
 		res, err := reader.Read(ctx)
 		require.NoError(t, err)
 		require.NotNil(t, res.Envelope)
-		assert.Equal(t, "liveview.click", res.Envelope.Event.Type)
+		assert.Equal(t, "liveview_click", res.Envelope.Event.Type)
 		assert.Equal(t, events.CategoryLiveview, res.Envelope.Event.Category)
 	})
 
@@ -77,12 +77,28 @@ func TestPublishEvent(t *testing.T) {
 		assert.Equal(t, http.StatusBadRequest, w.Code)
 	})
 
+	t.Run("empty_type_rejected", func(t *testing.T) {
+		logDir := t.TempDir()
+		svc, _ := newPublishTestService(t, logDir)
+
+		b, _ := json.Marshal(events.Event{
+			Category: events.CategoryConsole,
+			Data:     json.RawMessage(`{"x":1}`),
+		})
+		req := httptest.NewRequest(http.MethodPost, "/events/publish", bytes.NewReader(b))
+		req.Header.Set("Content-Type", "application/json")
+		w := httptest.NewRecorder()
+		svc.PublishEvent(w, req)
+
+		assert.Equal(t, http.StatusBadRequest, w.Code)
+	})
+
 	t.Run("liveview_routes_correctly", func(t *testing.T) {
 		logDir := t.TempDir()
 		svc, _ := newPublishTestService(t, logDir)
 
 		b, _ := json.Marshal(events.Event{
-			Type:     "liveview.click",
+			Type:     "liveview_click",
 			Category: events.CategoryLiveview,
 			Source:   events.Source{Kind: events.KindKernelAPI},
 			Data:     json.RawMessage(`{"x":100}`),
@@ -111,7 +127,7 @@ func TestPublishEvent(t *testing.T) {
 		svc, _ := newPublishTestService(t, logDir)
 
 		b, _ := json.Marshal(events.Event{
-			Type:     "captcha.solve",
+			Type:     "captcha_solve",
 			Category: events.CategoryCaptcha,
 			Source:   events.Source{Kind: events.KindKernelAPI},
 			Data:     json.RawMessage(`{"token":"abc"}`),

server/cmd/api/api/events_stream_test.go

@@ -19,12 +19,12 @@ func TestStreamEvents(t *testing.T) {
 
 		// Publish 2 events before streaming
 		cs.Publish(events.Event{
-			Type:     "console.log",
+			Type:     "console_log",
 			Category: events.CategoryConsole,
 			Source:   events.Source{Kind: events.KindCDP},
 		})
 		cs.Publish(events.Event{
-			Type:     "console.log",
+			Type:     "console_log",
 			Category: events.CategoryConsole,
 			Source:   events.Source{Kind: events.KindCDP},
 		})
@@ -50,9 +50,9 @@ func TestStreamEvents(t *testing.T) {
 		svc, cs := newPublishTestService(t, logDir)
 
 		// Publish 3 events
-		cs.Publish(events.Event{Type: "console.log", Category: events.CategoryConsole, Source: events.Source{Kind: events.KindCDP}})
-		cs.Publish(events.Event{Type: "console.log", Category: events.CategoryConsole, Source: events.Source{Kind: events.KindCDP}})
-		cs.Publish(events.Event{Type: "console.log", Category: events.CategoryConsole, Source: events.Source{Kind: events.KindCDP}})
+		cs.Publish(events.Event{Type: "console_log", Category: events.CategoryConsole, Source: events.Source{Kind: events.KindCDP}})
+		cs.Publish(events.Event{Type: "console_log", Category: events.CategoryConsole, Source: events.Source{Kind: events.KindCDP}})
+		cs.Publish(events.Event{Type: "console_log", Category: events.CategoryConsole, Source: events.Source{Kind: events.KindCDP}})
 
 		ctx, cancel := context.WithTimeout(context.Background(), 200*time.Millisecond)
 		defer cancel()

server/cmd/api/main.go

@@ -24,8 +24,8 @@ import (
 	"github.com/onkernel/kernel-images/server/cmd/config"
 	"github.com/onkernel/kernel-images/server/lib/chromedriverproxy"
 	"github.com/onkernel/kernel-images/server/lib/devtoolsproxy"
-	"github.com/onkernel/kernel-images/server/lib/logger"
 	"github.com/onkernel/kernel-images/server/lib/events"
+	"github.com/onkernel/kernel-images/server/lib/logger"
 	"github.com/onkernel/kernel-images/server/lib/nekoclient"
 	oapi "github.com/onkernel/kernel-images/server/lib/oapi"
 	"github.com/onkernel/kernel-images/server/lib/recorder"