Add auto-standby timer and lifecycle tests

Author: sjmiller609

lib/autostandby/controller_test.go

@@ -455,6 +455,86 @@ func TestRunDegradesWhenStartupResyncFails(t *testing.T) {
 	require.Equal(t, ReasonObserverError, status.Reason)
 }
 
+func TestHandleStandbyTimerCallsStandbyAndClearsState(t *testing.T) {
+	t.Parallel()
+
+	idleSince := time.Date(2026, 4, 6, 10, 55, 0, 0, time.UTC)
+	store := newFakeInstanceStore([]Instance{{
+		ID:             "inst-standby",
+		Name:           "inst-standby",
+		State:          StateRunning,
+		NetworkEnabled: true,
+		IP:             "192.168.100.61",
+		AutoStandby:    &Policy{Enabled: true, IdleTimeout: "1m"},
+		Runtime: &Runtime{
+			IdleSince: &idleSince,
+		},
+	}})
+	controller := NewController(store, &fakeConnectionSource{}, ControllerOptions{
+		Now: func() time.Time { return idleSince.Add(time.Minute) },
+	})
+
+	require.NoError(t, controller.startupResync(context.Background()))
+
+	controller.handleStandbyTimer(context.Background(), "inst-standby")
+
+	require.Equal(t, []string{"inst-standby"}, store.standbyIDs)
+	require.Nil(t, store.persistedRuntime["inst-standby"])
+
+	controller.mu.RLock()
+	state := controller.states["inst-standby"]
+	require.NotNil(t, state)
+	assert.Nil(t, state.compiledPolicy)
+	assert.Nil(t, state.activeInbound)
+	assert.Nil(t, state.idleSince)
+	assert.Nil(t, state.lastInboundAt)
+	assert.Nil(t, state.nextStandbyAt)
+	assert.False(t, state.standbyRequested)
+	controller.mu.RUnlock()
+}
+
+func TestHandleStandbyTimerFailureRearmsIdleCountdown(t *testing.T) {
+	t.Parallel()
+
+	idleSince := time.Date(2026, 4, 6, 10, 55, 0, 0, time.UTC)
+	now := idleSince.Add(time.Minute)
+	store := newFakeInstanceStore([]Instance{{
+		ID:             "inst-standby-fail",
+		Name:           "inst-standby-fail",
+		State:          StateRunning,
+		NetworkEnabled: true,
+		IP:             "192.168.100.62",
+		AutoStandby:    &Policy{Enabled: true, IdleTimeout: "1m"},
+		Runtime: &Runtime{
+			IdleSince: &idleSince,
+		},
+	}})
+	store.standbyErr = errors.New("standby failed")
+	controller := NewController(store, &fakeConnectionSource{}, ControllerOptions{
+		Now: func() time.Time { return now },
+	})
+
+	require.NoError(t, controller.startupResync(context.Background()))
+
+	controller.handleStandbyTimer(context.Background(), "inst-standby-fail")
+
+	require.Equal(t, []string{"inst-standby-fail"}, store.standbyIDs)
+	require.NotNil(t, store.persistedRuntime["inst-standby-fail"])
+	require.NotNil(t, store.persistedRuntime["inst-standby-fail"].IdleSince)
+	assert.Equal(t, now, *store.persistedRuntime["inst-standby-fail"].IdleSince)
+
+	controller.mu.RLock()
+	state := controller.states["inst-standby-fail"]
+	require.NotNil(t, state)
+	assert.NotNil(t, state.compiledPolicy)
+	assert.False(t, state.standbyRequested)
+	assert.NotNil(t, state.idleSince)
+	assert.Equal(t, now, *state.idleSince)
+	require.NotNil(t, state.nextStandbyAt)
+	assert.Equal(t, now.Add(time.Minute), *state.nextStandbyAt)
+	controller.mu.RUnlock()
+}
+
 func mustAddr(raw string) netip.Addr {
 	return netip.MustParseAddr(raw)
 }

lib/instances/update_test.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"errors"
 	"testing"
+	"time"
 
 	"github.com/kernel/hypeman/lib/autostandby"
 	"github.com/kernel/hypeman/lib/egressproxy"
@@ -239,3 +240,51 @@ func TestApplyUpdatedInstanceEnvSavesAutoStandbyAlongsideEnvWithoutMutatingOrigi
 	assert.Equal(t, "5m0s", original.AutoStandby.IdleTimeout)
 	assert.Equal(t, map[string]string{"OUTBOUND_OPENAI_KEY": "old"}, original.Env)
 }
+
+func TestManagerUpdateInstanceAutoStandbyOnlyPublishesLifecycleUpdate(t *testing.T) {
+	t.Parallel()
+
+	manager, _ := setupTestManager(t)
+	id := "inst-auto-standby-update"
+	require.NoError(t, manager.ensureDirectories(id))
+	meta := &metadata{
+		StoredMetadata: StoredMetadata{
+			Id:         id,
+			Name:       id,
+			CreatedAt:  time.Now(),
+			DataDir:    manager.paths.InstanceDir(id),
+			SocketPath: manager.paths.InstanceSocket(id, "cloud-hypervisor.sock"),
+			AutoStandby: &autostandby.Policy{
+				Enabled:     false,
+				IdleTimeout: "5m0s",
+			},
+		},
+	}
+	require.NoError(t, manager.saveMetadata(meta))
+
+	events, unsubscribe := manager.SubscribeLifecycleEvents(LifecycleEventConsumerAutoStandby)
+	defer unsubscribe()
+
+	updated, err := manager.UpdateInstance(context.Background(), id, UpdateInstanceRequest{
+		AutoStandby: &autostandby.Policy{
+			Enabled:     true,
+			IdleTimeout: "10m",
+		},
+	})
+	require.NoError(t, err)
+	require.NotNil(t, updated)
+	require.NotNil(t, updated.AutoStandby)
+	assert.True(t, updated.AutoStandby.Enabled)
+
+	select {
+	case event := <-events:
+		assert.Equal(t, LifecycleEventUpdate, event.Action)
+		assert.Equal(t, id, event.InstanceID)
+		require.NotNil(t, event.Instance)
+		require.NotNil(t, event.Instance.AutoStandby)
+		assert.True(t, event.Instance.AutoStandby.Enabled)
+		assert.Equal(t, "10m0s", event.Instance.AutoStandby.IdleTimeout)
+	case <-time.After(time.Second):
+		t.Fatal("timed out waiting for lifecycle update event")
+	}
+}