Deprecated since jdk9 replacing constructor instance of Double and Float#1660
Merged
kcooney merged 2 commits intojunit-team:mainfrom Aug 2, 2020
Merged
Deprecated since jdk9 replacing constructor instance of Double and Float#1660kcooney merged 2 commits intojunit-team:mainfrom
kcooney merged 2 commits intojunit-team:mainfrom
Conversation
sync to latest
Member
|
Can't we simply rely on autoboxing? |
RahulNagekar
force-pushed
the
DeprecatedSinceJDK9
branch
from
caaab0f to
31e461e
Compare
Contributor
Author
Right, good point. |
Member
|
@marcphilipp @RahulNagekar I personally prefer not using autoboxing here. Having an explicit conversion here makes it clear to future readers that a conversion is happening. |
Contributor
|
I'm also in favour for Double.valueOf so that the code is the same like in JUnit 4's |
Contributor
Author
|
I currently not sure if autoboxing would be more beneficial or valueOf (performance-wise). |
Replacing Deprecated datatype constructors
RahulNagekar
force-pushed
the
DeprecatedSinceJDK9
branch
from
f640dce to
4859dcb
Compare
stefanbirkner
approved these changes
Apr 23, 2020
marcphilipp
approved these changes
Apr 24, 2020
kcooney
approved these changes
Aug 2, 2020
This was referenced Oct 12, 2020
This was referenced Mar 18, 2021
Closed
Closed
This was referenced May 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.