Do not inject git:: to url when git 2.3.0 or above found#168
Merged
Conversation
Owner
Author
|
There are two alternatives that come to mind:
|
76d3e8d to
efcfa4e
Compare
Owner
Author
|
Implemented the second method. (We may need to revert the value of GIT_TERMINAL_PROMPT though.) |
efcfa4e to
7fec10e
Compare
junegunn
added a commit
that referenced
this pull request
Feb 15, 2015
Do not inject `git::` to url when git 2.3.0 or above found
|
Hi @junegunn, |
Owner
Author
|
@bruno- Thanks. I appreciate your feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #161
/cc @bruno-
This commit takes advantage of
$GIT_TERMINAL_PROMPTvariable added in git 2.3.0. So if the git installed on the system is 2.3.0 or above, vim-plug will not usegit::hack to prevent user prompt. However, the downside of the current implementation is that it runsgit --versioncommand on startup which should increase the startup time by a little.