Publish to npm with public access when package is scoped and public

By default, npm assumes packages with a scoped name are private. Scoped
package.jsons usually use the "private" field to signal they are expected
to be public. When running `init` on such a package, make studio-changes
pass `--access public` to npm publish so that the expected permissions
are set.

Author: m90

lib/init.js

@@ -16,6 +16,14 @@ function addScript(scripts, name, source) {
   return false;
 }
 
+function isScopedPublicPackage(pkg) {
+  return (
+    pkg.private === false &&
+    typeof pkg.name === 'string' &&
+    pkg.name.indexOf('@') === 0
+  );
+}
+
 module.exports = function (argv) {
   const json = fs.readFileSync('package.json', 'utf8');
   const pkg = JSON.parse(json);
@@ -49,13 +57,19 @@ module.exports = function (argv) {
       }
     }
   }
+
+  let postversion_script = 'git push --follow-tags && npm publish';
+  if (isScopedPublicPackage(pkg)) {
+    postversion_script += ' --access public';
+  }
+
   if (!has_commits && pkg.homepage) {
     version_script += ' --commits';
   }
 
   addScript(scripts, 'preversion', 'npm test');
   addScript(scripts, 'version', version_script);
-  addScript(scripts, 'postversion', 'git push --follow-tags && npm publish');
+  addScript(scripts, 'postversion', postversion_script);
 
   const indent = detectIndent(json).indent || '  ';
   const out = JSON.stringify(pkg, null, indent);

test/init-test.js

@@ -299,4 +299,53 @@ describe('init', () => {
 `
     );
   });
+
+  it('automatically passes `--access public` to scoped public packages', () => {
+    fs.readFileSync
+      .withArgs('package.json')
+      .returns('{"name":"@studio/changes","private":false}');
+
+    const result = init();
+
+    assert.isTrue(result);
+    assert.calledOnceWith(
+      fs.writeFileSync,
+      'package.json',
+      `{
+  "name": "@studio/changes",
+  "private": false,
+  "scripts": {
+    "preversion": "${SCRIPT_PREVERSION}",
+    "version": "${SCRIPT_VERSION}",
+    "postversion": "${SCRIPT_POSTVERSION} --access public"
+  }
+}
+`,
+      'utf8'
+    );
+  });
+
+  it('does not pass `--access` to packages implicitly restricted by a scoped name', () => {
+    fs.readFileSync
+      .withArgs('package.json')
+      .returns('{"name":"@acme-corp/ledger-tool"}');
+
+    const result = init();
+
+    assert.isTrue(result);
+    assert.calledOnceWith(
+      fs.writeFileSync,
+      'package.json',
+      `{
+  "name": "@acme-corp/ledger-tool",
+  "scripts": {
+    "preversion": "${SCRIPT_PREVERSION}",
+    "version": "${SCRIPT_VERSION}",
+    "postversion": "${SCRIPT_POSTVERSION}"
+  }
+}
+`,
+      'utf8'
+    );
+  });
 });