update go-tcp-transport to v0.2.2#8129
Merged
Merged
Conversation
aschmahmann
requested changes
May 12, 2021
aschmahmann
left a comment
aschmahmann
left a comment
Contributor
There was a problem hiding this comment.
There's a Go test that's failing and could be related to this update, if you could investigate what's going on (i.e. flaky test, problem, etc.) that'd be great 🙏
| github.com/multiformats/go-multiaddr-dns v0.3.1 | ||
| github.com/multiformats/go-multibase v0.0.3 | ||
| github.com/multiformats/go-multihash v0.0.14 | ||
| github.com/multiformats/go-multihash v0.0.15 |
Contributor
There was a problem hiding this comment.
Don't update go-multihash in this PR since it'll cause a sharness test failure (being solved in another PR). It also doesn't seem needed here.
Member
Author
There was a problem hiding this comment.
I didn't do this intentionally, go mod did this. It's because of this PR: libp2p/go-tcp-transport#75. I don't really understand why this PR pulled in go-multihash though.
aschmahmann
reviewed
May 13, 2021
marten-seemann
force-pushed
the
update-tcp
branch
from
58da786 to
bc68e2d
Compare
aschmahmann
approved these changes
May 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-tcp-transport v0.2.2 adds a bunch of low-level TCP Prometheus metrics. This is especially interesting for comparing QUIC and TCP.