feat(gw): expose /api/v0/dag/export on gateway port#8111
Conversation
- add dag/export to read-only root. it's ready only, so why the heck not! - test that i didn't expose other dag subcommands § License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
|
is there some magic to running a single sharness test (on macos)? I tried following the readme in the test dir but got errors. $ make test_sharness_deps
$ cd test/sharness
$ ./t0110-gateway.sh 15:35:40
lib/sharness/sharness.sh: line 888: syntax error: unexpected end of file
Cannot source: lib/sharness/sharness.sh
Please check Sharness installation.
FATAL: Unexpected exit with code 1 |
There was a problem hiding this comment.
LGTM, CI is green 🧙 ✨
This will effectively enable everyone to fetch CID from any gateway in a way that enables deterministic CID validation (ipfs/in-web-browsers#128), but without waiting for new fancy semantics discussed in ipfs/in-web-browsers#170. With this, tools like ipfs-or-gateway will be able to verify CID even when gateway is used.
We also want to explore this with Brave on mobile.
@aschmahmann I've added this to 0.9.0: this is a small and safe change that improves the utility of public gateways without opening any new doors (mind that we already expose /api/v0/refs 🤷♂️ ).
|
LGTM this seems like a pretty reasonable thing to do. |
License: MIT
Signed-off-by: Oli Evans oli@tableflip.io