doc: update curl usage in COLLABORATOR_GUIDE#1382
doc: update curl usage in COLLABORATOR_GUIDE#1382silverwind wants to merge 1 commit intonodejs:v1.xfrom
Conversation
|
LGTM but maybe add one or two lines to the commit log explaining the change. The idea is that when looking at the history, you don't have to look at the diff to figure out what the actual change was. |
|
Thanks, will do. |
Github now redirects the patch urls hosted on github.com, making it necessary to enable curl redirect handling to obtain patches in the merge process. Example (before and after): https://github.com/iojs/io.js/pull/1382.patch https://patch-diff.githubusercontent.com/raw/iojs/io.js/pull/1382.patch PR-URL: #1382 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in b464d46 |
|
btw there is apply-pr utility I wrote that has been pretty handy: https://github.com/petkaantonov/apply-pr Applying pr is like: |
|
Another option is to add |
|
Noted, but that is kinda annoying. cc @iojs/collaborators to notify the rest of the change. |
|
Another alternative is to make curl follow redirects by default: echo '-L' >> ~/.curlrc |
Looks like Github now redirects the patch urls from
to
so curl now needs to follow that redirect.