Add package.json validation to reject iobroker.js-controller as dependency (#696)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Apollon77 <11976694+Apollon77@users.noreply.github.com>
Co-authored-by: Ingo Fischer <github@fischer-ka.de>

Author: Copilot

CHANGELOG.md

@@ -7,6 +7,7 @@
 ## **WORK IN PROGRESS**
 * (@Apollon77/@copilot) Add validation for JSON files in admin/ and admin/i18n/ directories
 * (@Apollon77/@copilot) Logs npm and installation errors to console for easier debugging
+* (@Apollon77/@copilot) Add validation to fail if iobroker.js-controller is listed as a package.json dependency
 * (@Apollon77/@copilot) Add support for TypeScript-only adapters that use .ts files as main entry point without transpilation
 * (@Apollon77/@copilot) Re-enabled validation checks for README.md and LICENSE files in packageFiles tests
 

build/tests/packageFiles/index.js

@@ -166,6 +166,19 @@ function validatePackageFiles(adapterDir) {
                     }
                 }
             });
+            it('iobroker.js-controller is not listed as a dependency', () => {
+                for (const depType of [
+                    'dependencies',
+                    'devDependencies',
+                    'optionalDependencies',
+                    'peerDependencies',
+                ]) {
+                    if ((0, typeguards_1.isObject)(packageContent[depType]) && 'iobroker.js-controller' in packageContent[depType]) {
+                        // eslint-disable-next-line @typescript-eslint/only-throw-error
+                        throw new chai_1.AssertionError(`iobroker.js-controller must not be listed in ${depType}, found "${packageContent[depType]['iobroker.js-controller']}"!`);
+                    }
+                }
+            });
         });
         describe(`Check contents of io-package.json`, () => {
             beforeEach(function () {

src/tests/packageFiles/index.ts

@@ -154,6 +154,22 @@ export function validatePackageFiles(adapterDir: string): void {
                     }
                 }
             });
+
+            it('iobroker.js-controller is not listed as a dependency', () => {
+                for (const depType of [
+                    'dependencies',
+                    'devDependencies',
+                    'optionalDependencies',
+                    'peerDependencies',
+                ] as const) {
+                    if (isObject(packageContent[depType]) && 'iobroker.js-controller' in packageContent[depType]) {
+                        // eslint-disable-next-line @typescript-eslint/only-throw-error
+                        throw new AssertionError(
+                            `iobroker.js-controller must not be listed in ${depType}, found "${packageContent[depType]['iobroker.js-controller']}"!`,
+                        );
+                    }
+                }
+            });
         });
 
         describe(`Check contents of io-package.json`, () => {