fix(app, ios): use NSInteger not NSInteger* for prefs

the native API for user prefs takes NSInteger, conform to that

Author: mikehardy

packages/app/ios/RNFBApp/RNFBPreferences.h

@@ -25,13 +25,13 @@
 
 - (void)setBooleanValue:(NSString *)key boolValue:(BOOL)boolValue;
 
-- (void)setIntegerValue:(NSString *)key integerValue:(NSInteger *)integerValue;
+- (void)setIntegerValue:(NSString *)key integerValue:(NSInteger)integerValue;
 
 - (void)setStringValue:(NSString *)key stringValue:(NSString *)stringValue;
 
 - (NSString *)getStringValue:(NSString *)key defaultValue:(NSString *)defaultValue;
 
-- (NSInteger *)getIntegerValue:(NSString *)key defaultValue:(NSInteger *)defaultValue;
+- (NSInteger)getIntegerValue:(NSString *)key defaultValue:(NSInteger)defaultValue;
 
 - (NSDictionary *)getAll;
 

packages/app/ios/RNFBApp/RNFBPreferences.m

@@ -55,14 +55,14 @@ - (void)setBooleanValue:(NSString *)key boolValue:(BOOL)boolValue {
   [_userDefaults synchronize];
 }
 
-- (void)setIntegerValue:(NSString *)key integerValue:(NSInteger *)integerValue {
+- (void)setIntegerValue:(NSString *)key integerValue:(NSInteger)integerValue {
   [_userDefaults setInteger:(NSInteger)integerValue forKey:key];
   [_userDefaults synchronize];
 }
 
-- (NSInteger *)getIntegerValue:(NSString *)key defaultValue:(NSInteger *)defaultValue {
+- (NSInteger)getIntegerValue:(NSString *)key defaultValue:(NSInteger)defaultValue {
   if ([_userDefaults objectForKey:key] == nil) return defaultValue;
-  return (NSInteger *)[_userDefaults integerForKey:key];
+  return [_userDefaults integerForKey:key];
 }
 
 - (NSString *)getStringValue:(NSString *)key defaultValue:(NSString *)defaultValue {

packages/database/ios/RNFBDatabase/RNFBDatabaseCommon.m

@@ -85,8 +85,8 @@ + (void)setDatabaseConfig:(FIRDatabase *)firDatabase dbURL:(NSString *)dbURL {
 
     // Persistence cache size
     if ([preferences contains:DATABASE_PERSISTENCE_CACHE_SIZE]) {
-      NSInteger *cacheSizeBytes = [preferences getIntegerValue:DATABASE_PERSISTENCE_CACHE_SIZE
-                                                  defaultValue:(NSInteger *)10000000];
+      NSInteger cacheSizeBytes = [preferences getIntegerValue:DATABASE_PERSISTENCE_CACHE_SIZE
+                                                 defaultValue:10000000];
       [firDatabase setPersistenceCacheSizeBytes:(NSUInteger)cacheSizeBytes];
     }
 

packages/database/ios/RNFBDatabase/RNFBDatabaseModule.m

@@ -76,8 +76,9 @@ - (dispatch_queue_t)methodQueue {
 RCT_EXPORT_METHOD(setPersistenceCacheSizeBytes
                   : (FIRApp *)firebaseApp
                   : (NSString *)dbURL
-                  : (NSInteger *)bytes) {
-  [[RNFBPreferences shared] setIntegerValue:DATABASE_PERSISTENCE_CACHE_SIZE integerValue:bytes];
+                  : (NSNumber *_Nonnull)bytes) {
+  [[RNFBPreferences shared] setIntegerValue:DATABASE_PERSISTENCE_CACHE_SIZE
+                               integerValue:[bytes intValue]];
 }
 
 @end

packages/firestore/ios/RNFBFirestore/RNFBFirestoreCommon.m

@@ -66,14 +66,14 @@ + (void)setFirestoreSettings:(FIRFirestore *)firestore appName:(NSString *)appNa
   firestoreSettings.dispatchQueue = [self getFirestoreQueue];
 
   NSString *cacheKey = [NSString stringWithFormat:@"%@_%@", FIRESTORE_CACHE_SIZE, appName];
-  NSInteger *size = [preferences getIntegerValue:cacheKey defaultValue:0];
+  NSInteger size = [preferences getIntegerValue:cacheKey defaultValue:0];
 
-  if (size == (NSInteger *)-1) {
+  if (size == -1) {
     firestoreSettings.cacheSizeBytes = kFIRFirestoreCacheSizeUnlimited;
   } else if (size == 0) {
     firestoreSettings.cacheSizeBytes = firestore.settings.cacheSizeBytes;
   } else {
-    firestoreSettings.cacheSizeBytes = (int64_t)size;
+    firestoreSettings.cacheSizeBytes = size;
   }
 
   NSString *hostKey = [NSString stringWithFormat:@"%@_%@", FIRESTORE_HOST, appName];