From 8792517d0789313e1c688292ad9c485be9332fa8 Mon Sep 17 00:00:00 2001 From: Anil Vishnoi Date: Sun, 16 Feb 2025 19:05:11 -0800 Subject: [PATCH] Remove help function from individal Makefile to fix the function overlap warning Signed-off-by: Anil Vishnoi --- Makefiles/containers-base/Makefile | 4 ---- Makefiles/deployment/kind/Makefile | 4 ---- Makefiles/deployment/openshift/prod/Makefile | 4 ---- Makefiles/deployment/openshift/qa/Makefile | 3 --- Makefiles/devcontainer/Makefile | 4 ---- Makefiles/linting/Makefile | 4 ---- Makefiles/local/Makefile | 4 ---- Makefiles/podman-compose/Makefile | 4 ---- 8 files changed, 31 deletions(-) diff --git a/Makefiles/containers-base/Makefile b/Makefiles/containers-base/Makefile index 20439718..b8f1abd8 100644 --- a/Makefiles/containers-base/Makefile +++ b/Makefiles/containers-base/Makefile @@ -8,10 +8,6 @@ TARGET_IMAGE_ARCH?=amd64 CONTAINER_ENGINE?=docker #################### VALIDATION FUNCTIONS #################### -.PHONY: help -help: - @awk 'BEGIN {FS = ":.*##"; printf "\nUsage:\n make \033[36m\033[0m\n"} /^[a-zA-Z_0-9-]+:.*?##/ { printf " \033[36m%-18s\033[0m %s\n", $$1, $$2 } /^##@/ { printf "\n\033[1m%s\033[0m\n", substr($$0, 5) } ' $(MAKEFILE_LIST) - validate-container-engine: ifeq ($(CONTAINER_ENGINE),docker) @if ! command -v docker >/dev/null 2>&1; then \ diff --git a/Makefiles/deployment/kind/Makefile b/Makefiles/deployment/kind/Makefile index f225b8c5..c6181075 100644 --- a/Makefiles/deployment/kind/Makefile +++ b/Makefiles/deployment/kind/Makefile @@ -2,10 +2,6 @@ # ║ KIND Targets ║ # ╚══════════════════════════════════════════════════════════╝ -.PHONY: help -help: - @awk 'BEGIN {FS = ":.*##"; printf "\nUsage:\n make \033[36m\033[0m\n"} /^[a-zA-Z_0-9-]+:.*?##/ { printf " \033[36m%-18s\033[0m %s\n", $$1, $$2 } /^##@/ { printf "\n\033[1m%s\033[0m\n", substr($$0, 5) } ' $(MAKEFILE_LIST) - #################### VARIABLE DEFINITIONS #################### ILAB_KUBE_CONTEXT?=kind-instructlab-ui diff --git a/Makefiles/deployment/openshift/prod/Makefile b/Makefiles/deployment/openshift/prod/Makefile index 2edaeaaf..eb9bbc43 100644 --- a/Makefiles/deployment/openshift/prod/Makefile +++ b/Makefiles/deployment/openshift/prod/Makefile @@ -2,10 +2,6 @@ # ║ Production Openshift Deployment Targets ║ # ╚══════════════════════════════════════════════════════════╝ -.PHONY: help -help: - @awk 'BEGIN {FS = ":.*##"; printf "\nUsage:\n make \033[36m\033[0m\n"} /^[a-zA-Z_0-9-]+:.*?##/ { printf " \033[36m%-18s\033[0m %s\n", $$1, $$2 } /^##@/ { printf "\n\033[1m%s\033[0m\n", substr($$0, 5) } ' $(MAKEFILE_LIST) - #################### VARIABLE DEFINITIONS #################### SEALED_SECRETS_CONTROLLER_NAMESPACE=kube-system diff --git a/Makefiles/deployment/openshift/qa/Makefile b/Makefiles/deployment/openshift/qa/Makefile index 45aefb9f..8b79ec0b 100644 --- a/Makefiles/deployment/openshift/qa/Makefile +++ b/Makefiles/deployment/openshift/qa/Makefile @@ -1,9 +1,6 @@ # ╔══════════════════════════════════════════════════════════╗ # ║ QA Openshift Deployment Targets ║ # ╚══════════════════════════════════════════════════════════╝ -.PHONY: help -help: - @awk 'BEGIN {FS = ":.*##"; printf "\nUsage:\n make \033[36m\033[0m\n"} /^[a-zA-Z_0-9-]+:.*?##/ { printf " \033[36m%-18s\033[0m %s\n", $$1, $$2 } /^##@/ { printf "\n\033[1m%s\033[0m\n", substr($$0, 5) } ' $(MAKEFILE_LIST) #################### DEPLOYMENT FUNCTIONS #################### diff --git a/Makefiles/devcontainer/Makefile b/Makefiles/devcontainer/Makefile index 8acb2207..983f719b 100644 --- a/Makefiles/devcontainer/Makefile +++ b/Makefiles/devcontainer/Makefile @@ -2,10 +2,6 @@ # ║ Devcontainer Targets ║ # ╚══════════════════════════════════════════════════════════╝ -.PHONY: help -help: - @awk 'BEGIN {FS = ":.*##"; printf "\nUsage:\n make \033[36m\033[0m\n"} /^[a-zA-Z_0-9-]+:.*?##/ { printf " \033[36m%-18s\033[0m %s\n", $$1, $$2 } /^##@/ { printf "\n\033[1m%s\033[0m\n", substr($$0, 5) } ' $(MAKEFILE_LIST) - #################### DEPENDENCY FUNCTIONS #################### DEVCONTAINER_BINARY_EXISTS ?= $(shell command -v devcontainer) diff --git a/Makefiles/linting/Makefile b/Makefiles/linting/Makefile index 7dcd450a..cc5623f5 100644 --- a/Makefiles/linting/Makefile +++ b/Makefiles/linting/Makefile @@ -2,10 +2,6 @@ # ║ Linting Targets ║ # ╚══════════════════════════════════════════════════════════╝ -.PHONY: help -help: - @awk 'BEGIN {FS = ":.*##"; printf "\nUsage:\n make \033[36m\033[0m\n"} /^[a-zA-Z_0-9-]+:.*?##/ { printf " \033[36m%-18s\033[0m %s\n", $$1, $$2 } /^##@/ { printf "\n\033[1m%s\033[0m\n", substr($$0, 5) } ' $(MAKEFILE_LIST) - ###################### LINTING FUNCTIONS ##################### ##@ Lint commands - Commands for linting various file formats diff --git a/Makefiles/local/Makefile b/Makefiles/local/Makefile index ee4b18f1..83ecd6b8 100644 --- a/Makefiles/local/Makefile +++ b/Makefiles/local/Makefile @@ -2,10 +2,6 @@ # ║ Local Development Targets ║ # ╚══════════════════════════════════════════════════════════╝ -.PHONY: help -help: - @awk 'BEGIN {FS = ":.*##"; printf "\nUsage:\n make \033[36m\033[0m\n"} /^[a-zA-Z_0-9-]+:.*?##/ { printf " \033[36m%-18s\033[0m %s\n", $$1, $$2 } /^##@/ { printf "\n\033[1m%s\033[0m\n", substr($$0, 5) } ' $(MAKEFILE_LIST) - #################### DEPENDENCY FUNCTIONS #################### ##@ Local Deployment - Helper commands for deploying UI stack locally on your machine diff --git a/Makefiles/podman-compose/Makefile b/Makefiles/podman-compose/Makefile index 6a2343d2..cafce504 100644 --- a/Makefiles/podman-compose/Makefile +++ b/Makefiles/podman-compose/Makefile @@ -3,10 +3,6 @@ # ║ Container Runtime Compose Deployment Targets ║ # ╚══════════════════════════════════════════════════════════╝ -.PHONY: help -help: - @awk 'BEGIN {FS = ":.*##"; printf "\nUsage:\n make \033[36m\033[0m\n"} /^[a-zA-Z_0-9-]+:.*?##/ { printf " \033[36m%-18s\033[0m %s\n", $$1, $$2 } /^##@/ { printf "\n\033[1m%s\033[0m\n", substr($$0, 5) } ' $(MAKEFILE_LIST) - #################### DEPLOYMENT FUNCTIONS #################### ##@ Podman Deployment - Helper commands for deploying UI stack in Podman