test: iterate over providers array with for/of

Author: danielroe

test/e2e/no-ssr.test.ts

@@ -18,31 +18,32 @@ await setup({
 })
 
 describe('browser (ssr: false)', () => {
-  it.each(providers.map(p => p.name))('%s should render images', async (name) => {
-    const provider = providers.find(p => p.name === name)!
-    const providerPath = `/provider/${provider.name}`
-
-    const requests: string[] = []
-    const page = await createPage()
-    page.route('**', (route) => {
-      requests.push(route.request().url())
-      return route.continue()
-    })
-    page.goto(url(providerPath))
+  for (const provider of providers) {
+    it(`${provider.name} should render images`, async () => {
+      const providerPath = `/provider/${provider.name}`
 
-    await page.waitForSelector('img')
-    const images = await page.getByRole('img').all()
+      const requests: string[] = []
+      const page = await createPage()
+      page.route('**', (route) => {
+        requests.push(route.request().url())
+        return route.continue()
+      })
+      page.goto(url(providerPath))
 
-    expect(images).toHaveLength(provider.samples.length)
+      await page.waitForSelector('img')
+      const images = await page.getByRole('img').all()
 
-    const sources = await Promise.all(images.map(el => el.evaluate(e => e.getAttribute('src'))))
-    expect(sources).toMatchSnapshot()
+      expect(images).toHaveLength(provider.samples.length)
 
-    expect(requests.map(r => r.replace(url('/'), '/')).filter(r => r !== providerPath && !r.match(/\.(js|css)/))).toMatchSnapshot()
-  })
+      const sources = await Promise.all(images.map(el => el.evaluate(e => e.getAttribute('src'))))
+      expect(sources).toMatchSnapshot()
+
+      expect(requests.map(r => r.replace(url('/'), '/')).filter(r => r !== providerPath && !r.match(/\.(js|css)/))).toMatchSnapshot()
+    })
+  }
 
   it('should emit load and error events', async () => {
-    const page = await createPage(url('/events'))
+    const page = await createPage('/events')
     const logs: string[] = []
 
     page.on('console', (msg) => { logs.push(msg.text()) })

test/e2e/ssr.test.ts

@@ -17,30 +17,31 @@ await setup({
 })
 
 describe('browser (ssr: true)', () => {
-  it.each(providers.map(p => p.name))('%s should render images', async (name) => {
-    const provider = providers.find(p => p.name === name)!
-    const providerPath = `/provider/${provider.name}`
+  for (const provider of providers) {
+    it(`${provider.name} should render images`, async () => {
+      const providerPath = `/provider/${provider.name}`
 
-    const page = await createPage()
+      const page = await createPage()
 
-    const requests: string[] = []
-    page.route('**', (route) => {
-      requests.push(route.request().url())
-      return route.continue()
-    })
+      const requests: string[] = []
+      page.route('**', (route) => {
+        requests.push(route.request().url())
+        return route.continue()
+      })
 
-    page.goto(url(providerPath))
+      page.goto(url(providerPath))
 
-    await page.waitForSelector('img')
-    const images = await page.getByRole('img').all()
+      await page.waitForSelector('img')
+      const images = await page.getByRole('img').all()
 
-    expect(images).toHaveLength(provider.samples.length)
+      expect(images).toHaveLength(provider.samples.length)
 
-    const sources = await Promise.all(images.map(el => el.evaluate(e => e.getAttribute('src'))))
-    expect(sources).toMatchSnapshot()
+      const sources = await Promise.all(images.map(el => el.evaluate(e => e.getAttribute('src'))))
+      expect(sources).toMatchSnapshot()
 
-    expect(requests.map(r => r.replace(url('/'), '/')).filter(r => r !== providerPath && !r.match(/\.(js|css)/))).toMatchSnapshot()
-  })
+      expect(requests.map(r => r.replace(url('/'), '/')).filter(r => r !== providerPath && !r.match(/\.(js|css)/))).toMatchSnapshot()
+    })
+  }
 
   it('should emit load and error events', async () => {
     const page = await createPage()