Merged
Conversation
Member
Author
|
I have changed to move the buffers into the controllers themselves, to allow for the buffer size to depend on the hatches in the at |
should break less now
…gh them Implment a paintable overlay on pipes minor refactor of PipeRenderer this commit is too large
(doesnt work)
…rence to the controller
Member
|
Recipes will be done in a follow up PR with other missing recipes for 2.7 |
TechLord22
reviewed
Jul 10, 2023
src/main/java/gregtech/client/renderer/pipe/LaserPipeRenderer.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/client/renderer/pipe/LaserPipeRenderer.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/client/renderer/pipe/LaserPipeRenderer.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Override | ||
| protected void renderOtherLayers(BlockRenderLayer layer, CCRenderState renderState, PipeRenderContext renderContext) { |
Member
There was a problem hiding this comment.
Was there any way to potentially re-use some of the existing pipe rendering methods here, such as renderPipeCube or renderPipeSide?
src/main/java/gregtech/common/pipelike/laser/net/LaserNetWalker.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/pipelike/laser/net/LaserPipeNet.java
Outdated
Show resolved
Hide resolved
serenibyss
approved these changes
Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This adds an active transformer to transport energy to and from different energy hatches, and to new laser hatches using a new laser net. The laser pipes become emissive when transmitting energy.
Implementation Details
The hatch as a buffer of 4 UV amps, and it pushes it every tick.
PipeNetWalker::getSurroundingPipeSideswas added to be overridden by a net walker to constrain the sides it considers valid sides to walk to; this is used to constrain the laser net to walking on one axis.renderOtherLayersandcanRenderInLayerwas added toPipeRenderto allow subclasses to render in other layers.Outcome
Players can now transform and transport energy long distances.
Additional Information
Example setup
Potential Compatibility Issues
Any addon using the
preventAnimatedOpticalCablesconfig as it was renamed topreventAnimatedCables