Skip to content

Commit c39a9a0

Browse files
arndbmartinkpetersen
authored andcommitted
scsi: megaraid_mbox: Avoid double kfree()
Smatch found a double-free after my recent change: drivers/scsi/megaraid/megaraid_mbox.c:3474 megaraid_cmm_register() error: double free of 'adp' (line 3468) Since the object is no longer allocated in megaraid_cmm_register(), remove the kfree() as well. Fixes: c1f7275 ("scsi: megaraid_mbox: Reduce stack usage in megaraid_cmm_register()") Reported-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de> Link: https://patch.msgid.link/20260601210216.846809-1-arnd@kernel.org Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 1b6f03b commit c39a9a0

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

drivers/scsi/megaraid/megaraid_mm.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -998,8 +998,6 @@ mraid_mm_register_adp(mraid_mmadp_t *adapter)
998998

999999
dma_pool_destroy(adapter->pthru_dma_pool);
10001000

1001-
kfree(adapter);
1002-
10031001
return rval;
10041002
}
10051003

0 commit comments

Comments
 (0)