Skip to content

Commit a6169cb

Browse files
arndbaalexandrovich
authored andcommitted
ntfs3: avoid -Wmaybe-uninitialized warning
This warning shows up with gcc-10 now: In file included from fs/ntfs3/index.c:15: fs/ntfs3/index.c: In function 'indx_add_allocate': fs/ntfs3/ntfs_fs.h:463:9: error: 'bmp_size' may be used uninitialized in this function [-Werror=maybe-uninitialized] 463 | return attr_set_size_ex(ni, type, name, name_len, run, new_size, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 464 | new_valid, keep_prealloc, NULL, false); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/ntfs3/index.c:1498:6: note: 'bmp_size' was declared here 1498 | u64 bmp_size, bmp_size_v; | ^~~~~~~~ The warning does look correct, as the 'out2' label can be reached without initializing bmp_size and bmp_size_v. Initialize these at the same place as bmp. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
1 parent bb11485 commit a6169cb

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

fs/ntfs3/index.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1506,6 +1506,7 @@ static int indx_add_allocate(struct ntfs_index *indx, struct ntfs_inode *ni,
15061506

15071507
if (bit != MINUS_ONE_T) {
15081508
bmp = NULL;
1509+
bmp_size = bmp_size_v = 0;
15091510
} else {
15101511
if (bmp->non_res) {
15111512
bmp_size = le64_to_cpu(bmp->nres.data_size);

0 commit comments

Comments
 (0)