Skip to content

Commit a4c18ea

Browse files
Miao Lijic23
authored andcommitted
iio: light: stk3310: Use sizeof() for regmap_bulk_read/write count parameter
Convert the hardcoded count parameter to sizeof(buf) for all regmap_bulk_write() and regmap_bulk_read() calls in this driver to improve code maintainability. For details, see [1]. Link: https://lore.kernel.org/all/20260428192213.7c5c80e5@jic23-huawei/ #[1] Signed-off-by: Miao Li <limiao@kylinos.cn> Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
1 parent ac41294 commit a4c18ea

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

drivers/iio/light/stk3310.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ static int stk3310_read_event(struct iio_dev *indio_dev,
271271
return -EINVAL;
272272

273273
mutex_lock(&data->lock);
274-
ret = regmap_bulk_read(data->regmap, reg, &buf, 2);
274+
ret = regmap_bulk_read(data->regmap, reg, &buf, sizeof(buf));
275275
mutex_unlock(&data->lock);
276276
if (ret < 0) {
277277
dev_err(&data->client->dev, "register read failed\n");
@@ -311,7 +311,7 @@ static int stk3310_write_event(struct iio_dev *indio_dev,
311311
return -EINVAL;
312312

313313
buf = cpu_to_be16(val);
314-
ret = regmap_bulk_write(data->regmap, reg, &buf, 2);
314+
ret = regmap_bulk_write(data->regmap, reg, &buf, sizeof(buf));
315315
if (ret < 0) {
316316
dev_err(&client->dev, "failed to set PS threshold!\n");
317317
return ret;
@@ -389,7 +389,7 @@ static int stk3310_read_raw(struct iio_dev *indio_dev,
389389
reg = STK3310_REG_PS_DATA_MSB;
390390

391391
mutex_lock(&data->lock);
392-
ret = regmap_bulk_read(data->regmap, reg, &buf, 2);
392+
ret = regmap_bulk_read(data->regmap, reg, &buf, sizeof(buf));
393393
if (ret < 0) {
394394
dev_err(&client->dev, "register read failed\n");
395395
mutex_unlock(&data->lock);
@@ -739,7 +739,7 @@ static int stk3310_resume(struct device *dev)
739739

740740
if (data->ps_thdl != 0x0) {
741741
buf = cpu_to_be16(data->ps_thdl);
742-
ret = regmap_bulk_write(data->regmap, STK3310_REG_THDL_PS, &buf, 2);
742+
ret = regmap_bulk_write(data->regmap, STK3310_REG_THDL_PS, &buf, sizeof(buf));
743743
if (ret < 0) {
744744
dev_err(dev, "failed to set reg THDL_PS at resume.\n");
745745
return ret;
@@ -748,7 +748,7 @@ static int stk3310_resume(struct device *dev)
748748

749749
if (data->ps_thdh != STK3310_PS_MAX_VAL) {
750750
buf = cpu_to_be16(data->ps_thdh);
751-
ret = regmap_bulk_write(data->regmap, STK3310_REG_THDH_PS, &buf, 2);
751+
ret = regmap_bulk_write(data->regmap, STK3310_REG_THDH_PS, &buf, sizeof(buf));
752752
if (ret < 0) {
753753
dev_err(dev, "failed to set reg THDH_PS at resume.\n");
754754
return ret;

0 commit comments

Comments
 (0)