Skip to content

Commit 628105e

Browse files
rodrigo455jic23
authored andcommitted
iio: dac: ad5686: refactor include headers
Apply IWYU principle, replacing unused/generic headers for specific/missing headers. The resulting include directive lists are sorted accordingly. Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com> Signed-off-by: Rodrigo Alencar <rodrigo.alencar@analog.com> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
1 parent c82228f commit 628105e

4 files changed

Lines changed: 22 additions & 15 deletions

File tree

drivers/iio/dac/ad5686-spi.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,16 @@
88
* Copyright 2018 Analog Devices Inc.
99
*/
1010

11-
#include "ad5686.h"
12-
11+
#include <linux/array_size.h>
12+
#include <linux/errno.h>
13+
#include <linux/mod_devicetable.h>
1314
#include <linux/module.h>
1415
#include <linux/spi/spi.h>
1516

17+
#include <asm/byteorder.h>
18+
19+
#include "ad5686.h"
20+
1621
static int ad5686_spi_write(struct ad5686_state *st,
1722
u8 cmd, u8 addr, u16 val)
1823
{

drivers/iio/dac/ad5686.c

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,16 @@
55
* Copyright 2011 Analog Devices Inc.
66
*/
77

8-
#include <linux/interrupt.h>
9-
#include <linux/fs.h>
10-
#include <linux/device.h>
8+
#include <linux/array_size.h>
9+
#include <linux/bitops.h>
10+
#include <linux/errno.h>
11+
#include <linux/export.h>
12+
#include <linux/kstrtox.h>
1113
#include <linux/module.h>
12-
#include <linux/kernel.h>
13-
#include <linux/slab.h>
14-
#include <linux/sysfs.h>
1514
#include <linux/regulator/consumer.h>
15+
#include <linux/sysfs.h>
1616

1717
#include <linux/iio/iio.h>
18-
#include <linux/iio/sysfs.h>
1918

2019
#include "ad5686.h"
2120

drivers/iio/dac/ad5686.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,9 @@
88
#ifndef __DRIVERS_IIO_DAC_AD5686_H__
99
#define __DRIVERS_IIO_DAC_AD5686_H__
1010

11-
#include <linux/types.h>
12-
#include <linux/cache.h>
11+
#include <linux/bits.h>
1312
#include <linux/mutex.h>
14-
#include <linux/kernel.h>
13+
#include <linux/types.h>
1514

1615
#include <linux/iio/iio.h>
1716

drivers/iio/dac/ad5696-i2c.c

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,14 @@
77
* Copyright 2018 Analog Devices Inc.
88
*/
99

10-
#include "ad5686.h"
11-
12-
#include <linux/module.h>
10+
#include <linux/errno.h>
1311
#include <linux/i2c.h>
12+
#include <linux/mod_devicetable.h>
13+
#include <linux/module.h>
14+
15+
#include <asm/byteorder.h>
16+
17+
#include "ad5686.h"
1418

1519
static int ad5686_i2c_read(struct ad5686_state *st, u8 addr)
1620
{

0 commit comments

Comments
 (0)