Skip to content

Commit 32a5c04

Browse files
sanjay-embeddedjic23
authored andcommitted
iio: accel: mma8452: Use dev_err_probe()
dev_err_probe() makes error code handling simpler and handle deferred probe nicely (avoid spamming logs). Signed-off-by: Sanjay Chitroda <sanjayembeddedse@gmail.com> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
1 parent e9f1439 commit 32a5c04

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

drivers/iio/accel/mma8452.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1548,6 +1548,7 @@ MODULE_DEVICE_TABLE(of, mma8452_dt_ids);
15481548

15491549
static int mma8452_probe(struct i2c_client *client)
15501550
{
1551+
struct device *dev = &client->dev;
15511552
struct mma8452_data *data;
15521553
struct iio_dev *indio_dev;
15531554
int ret;
@@ -1580,14 +1581,12 @@ static int mma8452_probe(struct i2c_client *client)
15801581
"failed to get VDDIO regulator!\n");
15811582

15821583
ret = regulator_enable(data->vdd_reg);
1583-
if (ret) {
1584-
dev_err(&client->dev, "failed to enable VDD regulator!\n");
1585-
return ret;
1586-
}
1584+
if (ret)
1585+
return dev_err_probe(dev, ret, "failed to enable VDD regulator!\n");
15871586

15881587
ret = regulator_enable(data->vddio_reg);
15891588
if (ret) {
1590-
dev_err(&client->dev, "failed to enable VDDIO regulator!\n");
1589+
dev_err_probe(dev, ret, "failed to enable VDDIO regulator!\n");
15911590
goto disable_regulator_vdd;
15921591
}
15931592

0 commit comments

Comments
 (0)