Skip to content

Commit 21d822d

Browse files
committed
ACPI: button: Improve warning message regarding lid state
The warning message regarding an unexpected lid state printed by acpi_lid_notify_state() is quite cryptic and there is no information in it to indicate that it is about a platform firmware defect. In fact, it can only be understood after reading the comment below the statement printing it. For this reason, replace it with a more direct one including FW_BUG so its connection to a firmware issue is clearer. While at it, fix up a comment preceding the statement printing the message in question. Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Link: https://patch.msgid.link/5084775.GXAFRqVoOG@rafael.j.wysocki
1 parent c64db50 commit 21d822d

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/acpi/button.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,8 +227,8 @@ static int acpi_lid_notify_state(struct acpi_button *button, int state)
227227
ms_to_ktime(lid_report_interval));
228228
if (button->last_state == !!state &&
229229
ktime_after(ktime_get(), next_report)) {
230-
/* Complain the buggy firmware */
231-
pr_warn_once("The lid device is not compliant to SW_LID.\n");
230+
/* Complain about the buggy firmware. */
231+
pr_warn_once(FW_BUG "Unexpected lid state reported by firmware\n");
232232

233233
/*
234234
* Send the unreliable complement switch event:

0 commit comments

Comments
 (0)