Skip to content

Commit 0026688

Browse files
arndburezki
authored andcommitted
rcu/nocb: reduce stack usage in nocb_gp_wait()
When CONFIG_UBSAN_ALIGNMENT is enabled, the stack usage of nocb_gp_wait() grows above typical warning limits: In file included from kernel/rcu/tree.c:4930: kernel/rcu/tree_nocb.h: In function 'rcu_nocb_gp_kthread': kernel/rcu/tree_nocb.h:866:1: error: the frame size of 1968 bytes is larger than 1280 bytes [-Werror=frame-larger-than=] Apparently, the problem is passing rcu_data from a 'void *' pointer, which gcc assumes may be misaligned. When the function is not inlined into rcu_nocb_gp_kthread(), that is no longer visible to gcc. Add a 'noinline_for_stack' annotation that leads to skipping a lot of the alignment sanitizer checks and keeps the stack usage 60% lower here. Reviewed-by: Kunwu Chan <chentao@kylinos.cn> Reviewed-by: Frederic Weisbecker <frederic@kernel.org> Reviewed-by: Paul E. McKenney <paulmck@kernel.org> Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
1 parent 42c5468 commit 0026688

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

kernel/rcu/tree_nocb.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,7 @@ static void nocb_gp_sleep(struct rcu_data *my_rdp, int cpu)
655655
* No-CBs GP kthreads come here to wait for additional callbacks to show up
656656
* or for grace periods to end.
657657
*/
658-
static void nocb_gp_wait(struct rcu_data *my_rdp)
658+
static noinline_for_stack void nocb_gp_wait(struct rcu_data *my_rdp)
659659
{
660660
bool bypass = false;
661661
int __maybe_unused cpu = my_rdp->cpu;

0 commit comments

Comments
 (0)