fix(desktop): stabilize managed runtime status and errors - #110
Merged
Conversation
tulayha
marked this pull request as ready for review
August 7, 2026 10:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ready, distinguishNot installed,Unavailable, andStatus unknownfromOff, and identify actions that start a stopped service.The macOS setup failure occurred after package and model preparation because the final compatibility check rejected a legitimate virtual-environment interpreter symlink. The contradictory Windows page had a separate cause: worker status was polled on a fixed interval while earlier subprocesses could still be active, and a timeout stored in the shared page banner was not cleared by a later successful status. The tray also conflated installation readiness, capability availability, and service runtime state, producing combinations such as
Readywith an unavailable service labeledStopped.There is no storage migration or index rebuild.
Validation
python -m build— built the Python sdist and wheel consumed by the Desktop build.npm --prefix desktop run sidecar:windows— fetched and verified the pinned uv sidecar required by the Rust build on this machine.npm --prefix desktop run typecheck— checked the Desktop TypeScript project.npm --prefix desktop run lint— linted the Desktop frontend.npm --prefix desktop test -- --run src/App.test.tsx— ran 28 mocked Desktop UI lifecycle tests, including persistent install-failure and worker-timeout recovery coverage; this is not end-to-end validation.npm --prefix desktop run build— produced the production Vite frontend bundle.cargo test --locked --manifest-path desktop/src-tauri/Cargo.toml— ran all 81 Rust unit tests, including managed-runtime ownership and compact tray-state regressions.cargo fmt --manifest-path desktop/src-tauri/Cargo.toml -- --checkgit diff --checkA real macOS Desktop installer was not available from this Windows worktree, so the original installer path still needs a macOS smoke test.
BEGIN_COMMIT_OVERRIDE
chore(desktop): stabilize managed runtime status and errors
END_COMMIT_OVERRIDE