fix: update publish workflow - #22
Merged
Merged
Conversation
Collaborator
Author
|
Edit - this PR fixes #21 . However, the publish workflow still won't complete b/c but we admin change to make to ensure the pipeline runs. In the meantime I made a manual push to NPM with version bump to 0.1.4 (actually now 0.1.5 since there was another build error I discovered and fixed in the lastest commit in this branch) as specified in this PR. Let's address Monday @caio1985 |
…ncies The `npx @googlemaps/code-assist-mcp` command was failing for users due to two issues in the packaging process. First, the bundled output file in `dist/index.js` was not being marked as executable, leading to a `Permission denied` error when `npx` tried to run it. Second, the `express` and `cors` packages were listed as `devDependencies` but are required at runtime. This would have caused a "Cannot find module" error after fixing the permissions. This commit addresses both issues by: - Adding `shx chmod +x dist/index.js` to the `build:prepare` npm script. - Moving `express` and `cors` to the `dependencies` section in the package's `package.json`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix github release workflow